Require concrete api_key inputs in config and transport

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -32,7 +32,7 @@ def normalize_api_key(
         *,
         empty_error_message: str = "api_key must not be empty",
     ) -> str:
-        if not isinstance(api_key, str):
+        if type(api_key) is not str:
             raise HyperbrowserError("api_key must be a string")
         try:
             normalized_api_key = api_key.strip()

hyperbrowser/transport/base.py

@@ -64,7 +64,7 @@ def _format_mapping_key_for_error(key: str) -> str:
 
 
 def _normalize_transport_api_key(api_key: str) -> str:
-    if not isinstance(api_key, str):
+    if type(api_key) is not str:
         raise HyperbrowserError("api_key must be a string")
 
     try:

tests/test_config.py

@@ -318,55 +318,12 @@ def strip(self, chars=None):  # type: ignore[override]
         ClientConfig.resolve_base_url_from_env(_BrokenBaseUrl("https://example.local"))
 
 
-def test_client_config_wraps_api_key_strip_runtime_errors():
-    class _BrokenApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise RuntimeError("api key strip exploded")
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        ClientConfig(api_key=_BrokenApiKey("test-key"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_client_config_preserves_hyperbrowser_api_key_strip_errors():
-    class _BrokenApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom strip failure")
-
-    with pytest.raises(HyperbrowserError, match="custom strip failure") as exc_info:
-        ClientConfig(api_key=_BrokenApiKey("test-key"))
-
-    assert exc_info.value.original_error is None
-
-
-def test_client_config_wraps_non_string_api_key_strip_results():
-    class _BrokenApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return object()
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        ClientConfig(api_key=_BrokenApiKey("test-key"))
-
-    assert isinstance(exc_info.value.original_error, TypeError)
-
-
-def test_client_config_wraps_api_key_string_subclass_strip_results():
-    class _BrokenApiKey(str):
-        class _NormalizedKey(str):
-            pass
-
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return self._NormalizedKey("test-key")
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        ClientConfig(api_key=_BrokenApiKey("test-key"))
+def test_client_config_rejects_string_subclass_api_key_values():
+    class _ApiKey(str):
+        pass
 
-    assert isinstance(exc_info.value.original_error, TypeError)
+    with pytest.raises(HyperbrowserError, match="api_key must be a string"):
+        ClientConfig(api_key=_ApiKey("test-key"))
 
 
 def test_client_config_rejects_blank_api_key_values():

tests/test_transport_api_key.py

@@ -6,58 +6,12 @@
 
 
 @pytest.mark.parametrize("transport_class", [SyncTransport, AsyncTransport])
-def test_transport_wraps_api_key_strip_runtime_errors(transport_class):
-    class _BrokenStripApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise RuntimeError("api key strip exploded")
+def test_transport_rejects_string_subclass_api_keys(transport_class):
+    class _ApiKey(str):
+        pass
 
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        transport_class(api_key=_BrokenStripApiKey("test-key"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-@pytest.mark.parametrize("transport_class", [SyncTransport, AsyncTransport])
-def test_transport_preserves_hyperbrowser_api_key_strip_errors(transport_class):
-    class _BrokenStripApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom strip failure")
-
-    with pytest.raises(HyperbrowserError, match="custom strip failure") as exc_info:
-        transport_class(api_key=_BrokenStripApiKey("test-key"))
-
-    assert exc_info.value.original_error is None
-
-
-@pytest.mark.parametrize("transport_class", [SyncTransport, AsyncTransport])
-def test_transport_wraps_non_string_api_key_strip_results(transport_class):
-    class _NonStringStripResultApiKey(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return object()
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        transport_class(api_key=_NonStringStripResultApiKey("test-key"))
-
-    assert isinstance(exc_info.value.original_error, TypeError)
-
-
-@pytest.mark.parametrize("transport_class", [SyncTransport, AsyncTransport])
-def test_transport_wraps_api_key_string_subclass_strip_results(transport_class):
-    class _BrokenLengthApiKey(str):
-        class _NormalizedKey(str):
-            pass
-
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return self._NormalizedKey("test-key")
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize api_key") as exc_info:
-        transport_class(api_key=_BrokenLengthApiKey("test-key"))
-
-    assert isinstance(exc_info.value.original_error, TypeError)
+    with pytest.raises(HyperbrowserError, match="api_key must be a string"):
+        transport_class(api_key=_ApiKey("test-key"))
 
 
 @pytest.mark.parametrize("transport_class", [SyncTransport, AsyncTransport])