Require concrete base URL input types

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/config.py

@@ -112,7 +112,7 @@ def _safe_unquote(value: str, *, component_label: str) -> str:
 
     @staticmethod
     def normalize_base_url(base_url: str) -> str:
-        if not isinstance(base_url, str):
+        if type(base_url) is not str:
             raise HyperbrowserError("base_url must be a string")
         try:
             stripped_base_url = base_url.strip()

tests/test_config.py

@@ -295,43 +295,13 @@ def test_client_config_rejects_non_string_values():
         ClientConfig(api_key="bad\nkey")
 
 
-def test_client_config_normalize_base_url_wraps_strip_runtime_errors():
+def test_client_config_normalize_base_url_rejects_string_subclass_inputs():
     class _BrokenBaseUrl(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise RuntimeError("base_url strip exploded")
-
-    with pytest.raises(HyperbrowserError, match="Failed to normalize base_url") as exc_info:
-        ClientConfig.normalize_base_url(_BrokenBaseUrl("https://example.local"))
-
-    assert isinstance(exc_info.value.original_error, RuntimeError)
-
-
-def test_client_config_normalize_base_url_preserves_hyperbrowser_strip_errors():
-    class _BrokenBaseUrl(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom base_url strip failure")
-
-    with pytest.raises(
-        HyperbrowserError, match="custom base_url strip failure"
-    ) as exc_info:
-        ClientConfig.normalize_base_url(_BrokenBaseUrl("https://example.local"))
-
-    assert exc_info.value.original_error is None
-
-
-def test_client_config_normalize_base_url_wraps_non_string_strip_results():
-    class _BrokenBaseUrl(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            return object()
+        pass
 
-    with pytest.raises(HyperbrowserError, match="Failed to normalize base_url") as exc_info:
+    with pytest.raises(HyperbrowserError, match="base_url must be a string"):
         ClientConfig.normalize_base_url(_BrokenBaseUrl("https://example.local"))
 
-    assert isinstance(exc_info.value.original_error, TypeError)
-
 
 def test_client_config_resolve_base_url_from_env_rejects_string_subclass_inputs():
     class _BrokenBaseUrl(str):