Enforce concrete header name key types

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/header_utils.py

@@ -49,7 +49,7 @@ def normalize_headers(
     for key, value in _read_header_items(
         headers, mapping_error_message=mapping_error_message
     ):
-        if not isinstance(key, str) or not isinstance(value, str):
+        if type(key) is not str or not isinstance(value, str):
             raise HyperbrowserError(effective_pair_error_message)
         try:
             normalized_key = key.strip()

tests/test_header_utils.py

@@ -36,30 +36,6 @@ def items(self):
         return [self._broken_item]
 
 
-class _BrokenStripHeaderName(str):
-    def strip(self, chars=None):  # type: ignore[override]
-        _ = chars
-        raise RuntimeError("header strip exploded")
-
-
-class _BrokenLowerHeaderName(str):
-    def strip(self, chars=None):  # type: ignore[override]
-        _ = chars
-        return self
-
-    def lower(self):  # type: ignore[override]
-        raise RuntimeError("header lower exploded")
-
-
-class _NonStringLowerHeaderName(str):
-    def strip(self, chars=None):  # type: ignore[override]
-        _ = chars
-        return self
-
-    def lower(self):  # type: ignore[override]
-        return object()
-
-
 class _StringSubclassStripResultHeaderName(str):
     class _NormalizedKey(str):
         pass
@@ -118,68 +94,15 @@ def test_normalize_headers_rejects_empty_header_name():
         )
 
 
-def test_normalize_headers_wraps_header_name_strip_failures():
+def test_normalize_headers_rejects_string_subclass_header_names():
     with pytest.raises(
-        HyperbrowserError, match="Failed to normalize header name"
-    ) as exc_info:
-        normalize_headers(
-            {_BrokenStripHeaderName("X-Trace-Id"): "trace-1"},
-            mapping_error_message="headers must be a mapping of string pairs",
-        )
-
-    assert exc_info.value.original_error is not None
-
-
-def test_normalize_headers_preserves_hyperbrowser_header_name_strip_failures():
-    class _BrokenStripHeaderName(str):
-        def strip(self, chars=None):  # type: ignore[override]
-            _ = chars
-            raise HyperbrowserError("custom strip failure")
-
-    with pytest.raises(HyperbrowserError, match="custom strip failure") as exc_info:
-        normalize_headers(
-            {_BrokenStripHeaderName("X-Trace-Id"): "trace-1"},
-            mapping_error_message="headers must be a mapping of string pairs",
-        )
-
-    assert exc_info.value.original_error is None
-
-
-def test_normalize_headers_wraps_header_name_lower_failures():
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize header name"
-    ) as exc_info:
-        normalize_headers(
-            {_BrokenLowerHeaderName("X-Trace-Id"): "trace-1"},
-            mapping_error_message="headers must be a mapping of string pairs",
-        )
-
-    assert exc_info.value.original_error is not None
-
-
-def test_normalize_headers_wraps_non_string_header_name_lower_results():
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize header name"
-    ) as exc_info:
-        normalize_headers(
-            {_NonStringLowerHeaderName("X-Trace-Id"): "trace-1"},
-            mapping_error_message="headers must be a mapping of string pairs",
-        )
-
-    assert exc_info.value.original_error is not None
-
-
-def test_normalize_headers_wraps_string_subclass_header_name_strip_results():
-    with pytest.raises(
-        HyperbrowserError, match="Failed to normalize header name"
-    ) as exc_info:
+        HyperbrowserError, match="headers must be a mapping of string pairs"
+    ):
         normalize_headers(
             {_StringSubclassStripResultHeaderName("X-Trace-Id"): "trace-1"},
             mapping_error_message="headers must be a mapping of string pairs",
         )
 
-    assert isinstance(exc_info.value.original_error, TypeError)
-
 
 def test_normalize_headers_rejects_overly_long_header_names():
     long_header_name = "X-" + ("a" * 255)