Skip to content

Commit eed6d2a

Browse files
Standardize transport wrapper failure message format
Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>
1 parent b9dbe82 commit eed6d2a

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

hyperbrowser/transport/async_transport.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ async def post(
9494
raise
9595
except Exception as e:
9696
raise HyperbrowserError(
97-
f"POST request to {url} failed", original_error=e
97+
f"Request POST {url} failed", original_error=e
9898
) from e
9999

100100
async def get(
@@ -118,7 +118,7 @@ async def get(
118118
raise
119119
except Exception as e:
120120
raise HyperbrowserError(
121-
f"GET request to {url} failed", original_error=e
121+
f"Request GET {url} failed", original_error=e
122122
) from e
123123

124124
async def put(self, url: str, data: Optional[dict] = None) -> APIResponse:
@@ -136,7 +136,7 @@ async def put(self, url: str, data: Optional[dict] = None) -> APIResponse:
136136
raise
137137
except Exception as e:
138138
raise HyperbrowserError(
139-
f"PUT request to {url} failed", original_error=e
139+
f"Request PUT {url} failed", original_error=e
140140
) from e
141141

142142
async def delete(self, url: str) -> APIResponse:
@@ -154,5 +154,5 @@ async def delete(self, url: str) -> APIResponse:
154154
raise
155155
except Exception as e:
156156
raise HyperbrowserError(
157-
f"DELETE request to {url} failed", original_error=e
157+
f"Request DELETE {url} failed", original_error=e
158158
) from e

hyperbrowser/transport/sync.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def post(
8585
raise
8686
except Exception as e:
8787
raise HyperbrowserError(
88-
f"POST request to {url} failed", original_error=e
88+
f"Request POST {url} failed", original_error=e
8989
) from e
9090

9191
def get(
@@ -109,7 +109,7 @@ def get(
109109
raise
110110
except Exception as e:
111111
raise HyperbrowserError(
112-
f"GET request to {url} failed", original_error=e
112+
f"Request GET {url} failed", original_error=e
113113
) from e
114114

115115
def put(self, url: str, data: Optional[dict] = None) -> APIResponse:
@@ -127,7 +127,7 @@ def put(self, url: str, data: Optional[dict] = None) -> APIResponse:
127127
raise
128128
except Exception as e:
129129
raise HyperbrowserError(
130-
f"PUT request to {url} failed", original_error=e
130+
f"Request PUT {url} failed", original_error=e
131131
) from e
132132

133133
def delete(self, url: str) -> APIResponse:
@@ -145,5 +145,5 @@ def delete(self, url: str) -> APIResponse:
145145
raise
146146
except Exception as e:
147147
raise HyperbrowserError(
148-
f"DELETE request to {url} failed", original_error=e
148+
f"Request DELETE {url} failed", original_error=e
149149
) from e

tests/test_transport_response_handling.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def failing_post(*args, **kwargs):
267267
transport.client.post = failing_post # type: ignore[assignment]
268268
try:
269269
with pytest.raises(
270-
HyperbrowserError, match="POST request to https://example.com/post failed"
270+
HyperbrowserError, match="Request POST https://example.com/post failed"
271271
):
272272
transport.post("https://example.com/post", data={"ok": True})
273273
finally:
@@ -309,7 +309,7 @@ def failing_delete(*args, **kwargs):
309309
try:
310310
with pytest.raises(
311311
HyperbrowserError,
312-
match="DELETE request to https://example.com/delete failed",
312+
match="Request DELETE https://example.com/delete failed",
313313
):
314314
transport.delete("https://example.com/delete")
315315
finally:
@@ -329,7 +329,7 @@ async def failing_put(*args, **kwargs):
329329
try:
330330
with pytest.raises(
331331
HyperbrowserError,
332-
match="PUT request to https://example.com/put failed",
332+
match="Request PUT https://example.com/put failed",
333333
):
334334
await transport.put("https://example.com/put", data={"ok": True})
335335
finally:

0 commit comments

Comments
 (0)