Require plain UpdateSessionProfileParams in session managers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/session.py

@@ -247,12 +247,16 @@ async def update_profile_params(
     ) -> BasicResponse:
         params_obj: UpdateSessionProfileParams
 
-        if isinstance(params, UpdateSessionProfileParams):
+        if type(params) is UpdateSessionProfileParams:
             if persist_changes is not None:
                 raise HyperbrowserError(
                     "Pass either UpdateSessionProfileParams as the second argument or persist_changes=bool, not both."
                 )
             params_obj = params
+        elif isinstance(params, UpdateSessionProfileParams):
+            raise HyperbrowserError(
+                "update_profile_params() requires a plain UpdateSessionProfileParams object."
+            )
         elif isinstance(params, bool):
             if persist_changes is not None:
                 raise HyperbrowserError(

hyperbrowser/client/managers/sync_manager/session.py

@@ -239,12 +239,16 @@ def update_profile_params(
     ) -> BasicResponse:
         params_obj: UpdateSessionProfileParams
 
-        if isinstance(params, UpdateSessionProfileParams):
+        if type(params) is UpdateSessionProfileParams:
             if persist_changes is not None:
                 raise HyperbrowserError(
                     "Pass either UpdateSessionProfileParams as the second argument or persist_changes=bool, not both."
                 )
             params_obj = params
+        elif isinstance(params, UpdateSessionProfileParams):
+            raise HyperbrowserError(
+                "update_profile_params() requires a plain UpdateSessionProfileParams object."
+            )
         elif isinstance(params, bool):
             if persist_changes is not None:
                 raise HyperbrowserError(

tests/test_session_update_profile_params.py

@@ -95,6 +95,16 @@ def test_sync_update_profile_params_rejects_conflicting_arguments():
         )
 
 
+def test_sync_update_profile_params_rejects_subclass_params():
+    class _Params(UpdateSessionProfileParams):
+        pass
+
+    manager = SyncSessionManager(_SyncClient())
+
+    with pytest.raises(HyperbrowserError, match="plain UpdateSessionProfileParams"):
+        manager.update_profile_params("session-1", _Params(persist_changes=True))
+
+
 def test_async_update_profile_params_bool_warns_and_serializes():
     AsyncSessionManager._has_warned_update_profile_params_boolean_deprecated = False
     client = _AsyncClient()
@@ -138,6 +148,22 @@ async def run() -> None:
     asyncio.run(run())
 
 
+def test_async_update_profile_params_rejects_subclass_params():
+    class _Params(UpdateSessionProfileParams):
+        pass
+
+    manager = AsyncSessionManager(_AsyncClient())
+
+    async def run() -> None:
+        with pytest.raises(HyperbrowserError, match="plain UpdateSessionProfileParams"):
+            await manager.update_profile_params(
+                "session-1",
+                _Params(persist_changes=True),
+            )
+
+    asyncio.run(run())
+
+
 def test_sync_update_profile_params_requires_argument_or_keyword():
     manager = SyncSessionManager(_SyncClient())