Add architecture guard for shared model request helper reuse

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -133,6 +133,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_manager_transport_boundary.py` (manager transport boundary enforcement through shared request helpers),
   - `tests/test_mapping_keys_access_usage.py` (centralized key-iteration boundaries),
   - `tests/test_mapping_reader_usage.py` (shared mapping-read parser usage),
+  - `tests/test_model_request_internal_reuse.py` (request-helper internal reuse of shared model request helper primitives),
   - `tests/test_optional_serialization_helper_usage.py` (optional model serialization helper usage enforcement),
   - `tests/test_page_params_helper_usage.py` (paginated manager page-params helper usage enforcement),
   - `tests/test_plain_list_helper_usage.py` (shared plain-list normalization helper usage enforcement),

tests/test_architecture_marker_usage.py

@@ -23,6 +23,7 @@
     "tests/test_manager_transport_boundary.py",
     "tests/test_mapping_reader_usage.py",
     "tests/test_mapping_keys_access_usage.py",
+    "tests/test_model_request_internal_reuse.py",
     "tests/test_tool_mapping_reader_usage.py",
     "tests/test_display_helper_usage.py",
     "tests/test_binary_file_open_helper_usage.py",

tests/test_model_request_internal_reuse.py

@@ -0,0 +1,53 @@
+from pathlib import Path
+
+import pytest
+
+pytestmark = pytest.mark.architecture
+
+
+MODULES_THAT_MUST_REUSE_SHARED_MODEL_REQUEST_HELPERS = (
+    "hyperbrowser/client/managers/computer_action_request_utils.py",
+    "hyperbrowser/client/managers/extension_request_utils.py",
+    "hyperbrowser/client/managers/job_request_utils.py",
+    "hyperbrowser/client/managers/profile_request_utils.py",
+    "hyperbrowser/client/managers/team_request_utils.py",
+)
+
+MODULE_DISALLOWED_MARKERS = {
+    "hyperbrowser/client/managers/computer_action_request_utils.py": (
+        "client.transport.",
+        "parse_response_model(",
+    ),
+    "hyperbrowser/client/managers/extension_request_utils.py": (
+        "client.transport.post(",
+        "parse_response_model(",
+    ),
+    "hyperbrowser/client/managers/job_request_utils.py": (
+        "client.transport.",
+        "parse_response_model(",
+    ),
+    "hyperbrowser/client/managers/profile_request_utils.py": (
+        "client.transport.",
+        "parse_response_model(",
+    ),
+    "hyperbrowser/client/managers/team_request_utils.py": (
+        "client.transport.",
+        "parse_response_model(",
+    ),
+}
+
+
+def test_request_helpers_reuse_shared_model_request_helpers():
+    violating_modules: list[str] = []
+    for module_path in MODULES_THAT_MUST_REUSE_SHARED_MODEL_REQUEST_HELPERS:
+        module_text = Path(module_path).read_text(encoding="utf-8")
+        if "model_request_utils import" not in module_text:
+            violating_modules.append(module_path)
+            continue
+        if any(
+            marker in module_text
+            for marker in MODULE_DISALLOWED_MARKERS[module_path]
+        ):
+            violating_modules.append(module_path)
+
+    assert violating_modules == []