Share extension list response parsing across managers

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/async_manager/extension.py

@@ -2,6 +2,7 @@
 
 from hyperbrowser.exceptions import HyperbrowserError
 from ...file_utils import ensure_existing_file_path
+from ..extension_utils import parse_extension_list_response_data
 from hyperbrowser.models.extension import CreateExtensionParams, ExtensionResponse
 
 
@@ -38,18 +39,4 @@ async def list(self) -> List[ExtensionResponse]:
         response = await self._client.transport.get(
             self._client._build_url("/extensions/list"),
         )
-        if not isinstance(response.data, dict):
-            raise HyperbrowserError(
-                f"Expected dict response but got {type(response.data)}"
-            )
-        if "extensions" not in response.data:
-            raise HyperbrowserError(
-                f"Expected 'extensions' key in response but got {response.data.keys()}"
-            )
-        if not isinstance(response.data["extensions"], list):
-            raise HyperbrowserError(
-                f"Expected list in 'extensions' key but got {type(response.data['extensions'])}"
-            )
-        return [
-            ExtensionResponse(**extension) for extension in response.data["extensions"]
-        ]
+        return parse_extension_list_response_data(response.data)

hyperbrowser/client/managers/extension_utils.py

@@ -0,0 +1,18 @@
+from typing import Any, List
+
+from hyperbrowser.exceptions import HyperbrowserError
+from hyperbrowser.models.extension import ExtensionResponse
+
+
+def parse_extension_list_response_data(response_data: Any) -> List[ExtensionResponse]:
+    if not isinstance(response_data, dict):
+        raise HyperbrowserError(f"Expected dict response but got {type(response_data)}")
+    if "extensions" not in response_data:
+        raise HyperbrowserError(
+            f"Expected 'extensions' key in response but got {response_data.keys()}"
+        )
+    if not isinstance(response_data["extensions"], list):
+        raise HyperbrowserError(
+            f"Expected list in 'extensions' key but got {type(response_data['extensions'])}"
+        )
+    return [ExtensionResponse(**extension) for extension in response_data["extensions"]]

hyperbrowser/client/managers/sync_manager/extension.py

@@ -2,6 +2,7 @@
 
 from hyperbrowser.exceptions import HyperbrowserError
 from ...file_utils import ensure_existing_file_path
+from ..extension_utils import parse_extension_list_response_data
 from hyperbrowser.models.extension import CreateExtensionParams, ExtensionResponse
 
 
@@ -38,18 +39,4 @@ def list(self) -> List[ExtensionResponse]:
         response = self._client.transport.get(
             self._client._build_url("/extensions/list"),
         )
-        if not isinstance(response.data, dict):
-            raise HyperbrowserError(
-                f"Expected dict response but got {type(response.data)}"
-            )
-        if "extensions" not in response.data:
-            raise HyperbrowserError(
-                f"Expected 'extensions' key in response but got {response.data.keys()}"
-            )
-        if not isinstance(response.data["extensions"], list):
-            raise HyperbrowserError(
-                f"Expected list in 'extensions' key but got {type(response.data['extensions'])}"
-            )
-        return [
-            ExtensionResponse(**extension) for extension in response.data["extensions"]
-        ]
+        return parse_extension_list_response_data(response.data)

tests/test_extension_utils.py

@@ -0,0 +1,39 @@
+import pytest
+
+from hyperbrowser.client.managers.extension_utils import (
+    parse_extension_list_response_data,
+)
+from hyperbrowser.exceptions import HyperbrowserError
+
+
+def test_parse_extension_list_response_data_parses_extensions():
+    parsed = parse_extension_list_response_data(
+        {
+            "extensions": [
+                {
+                    "id": "ext_123",
+                    "name": "my-extension",
+                    "createdAt": "2026-01-01T00:00:00Z",
+                    "updatedAt": "2026-01-01T00:00:00Z",
+                }
+            ]
+        }
+    )
+
+    assert len(parsed) == 1
+    assert parsed[0].id == "ext_123"
+
+
+def test_parse_extension_list_response_data_rejects_non_dict_payload():
+    with pytest.raises(HyperbrowserError, match="Expected dict response"):
+        parse_extension_list_response_data(["not-a-dict"])  # type: ignore[arg-type]
+
+
+def test_parse_extension_list_response_data_rejects_missing_extensions_key():
+    with pytest.raises(HyperbrowserError, match="Expected 'extensions' key"):
+        parse_extension_list_response_data({})
+
+
+def test_parse_extension_list_response_data_rejects_non_list_extensions():
+    with pytest.raises(HyperbrowserError, match="Expected list in 'extensions' key"):
+        parse_extension_list_response_data({"extensions": "not-a-list"})