Add tag to "subscribe" to an issue

[andyg0808]

As a developer
I want to know which pulls I should look at
So that I can avoid wasting effort by forgetting to come back to partially-reviewed pulls

Let's add a tag which immediately marks a pull as having an out-of-date CR from that dev. This makes it easy to both reserve pulls (if you're in the middle of a CR on them) and to mark pulls which you've been involved in (to avoid duplication of effort from other devs).

[danielbeardsley]

Can you be a little more explicit here? What's tag? Does this tagged state live on somewhere? I remember us talking about highlighting pulls you've commented on (but not reviewed yet). Is this the same thing?

[andyg0808]

By tag I mean the signoff indicators we add to comments, like these:

pulldasher/config.example.js

Lines 106 to 137 in edfd343

	// Tags which indicate a comment is significant and should be parsed.
	// The regex may be customized to change the tag used in GitHub.
	tags: [
	{
	name: 'dev_block',
	// This regex supports thins like :smile: as well as the actual
	// unicode representation of emoticons. Mainly added because github
	// started making their autocompletor inject actual unicode emojis
	// in the text.
	regex: new RegExp("\\bdev_block " + signature, "i")
	},
	{
	name: 'un_dev_block',
	regex: new RegExp("\\bun_dev_block " + signature, "i")
	},
	{
	name: 'deploy_block',
	regex: new RegExp("\\bdeploy_block " + signature, "i")
	},
	{
	name: 'un_deploy_block',
	regex: new RegExp("\\bun_deploy_block " + signature, "i")
	},
	{
	name: 'QA',
	regex: new RegExp("\\bQA " + signature, "i")
	},
	{
	name: 'CR',
	regex: new RegExp("\\bCR " + signature, "i")
	}
	],

In this case, it would be an additional tag we can use to mean that a pull should be treated as though it has an out-of-date CR from you. I think it's the same idea as the "highlight pulls you've commented on," but with a deliberate invocation, rather than just being anything you've commented on. (Both might be worthwhile, but with different displays.)

[andyg0808]

I kinda think this would still be good. I'm not sure exactly what the implementation should be, but it shouldn't need to be particularly complex. @lithobraking, can we reopen it?

[danielbeardsley]

I don't think you need permission to re-open. Their intent was to close all the old issues and let folks re-open ones that are still relevant.

[andyg0808]

Something like this could also be useful in preventing someone else from merging a pull until you finish CR.