From 5aafbd260b58da7f4969840524bc69e64b6a8e53 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Fri, 10 Jan 2025 17:08:25 +0100 Subject: [PATCH 1/3] [ci] Use key4hep-build action for Key4hep builds --- .github/workflows/key4hep.yml | 47 +++++++++++++++-------------------- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/.github/workflows/key4hep.yml b/.github/workflows/key4hep.yml index 2aeaf77..aaf8f75 100644 --- a/.github/workflows/key4hep.yml +++ b/.github/workflows/key4hep.yml @@ -1,34 +1,27 @@ -name: key4hep +name: Key4hep build -on: [push, pull_request] +on: + push: + branches: + - master + pull_request: + workflow_dispatch: + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true jobs: - linux: - runs-on: ubuntu-latest + build: strategy: - fail-fast: false matrix: - include: - - release: "sw.hsf.org/key4hep" - CXX_STANDARD: 17 - - release: "sw-nightlies.hsf.org/key4hep" - CXX_STANDARD: 20 + build_type: ["release", "nightly"] + image: ["alma9", "ubuntu22"] + fail-fast: false + runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: cvmfs-contrib/github-action-cvmfs@v3 - - uses: aidasoft/run-lcg-view@v4 + - uses: actions/checkout@v4 + - uses: key4hep/key4hep-actions/key4hep-build@main with: - container: centos7 - view-path: /cvmfs/${{ matrix.release }} - run: | - mkdir build install - cd build - cmake -DCMAKE_CXX_STANDARD=${{ matrix.CXX_STANDARD }} \ - -DCMAKE_CXX_FLAGS="-fdiagnostics-color=always " \ - -DCMAKE_INSTALL_PREFIX=../install \ - -DINSTALL_DOC=ON \ - -GNinja \ - .. - ninja -k0 - ctest --output-on-failure - ninja install + build_type: ${{ matrix.build_type }} + image: ${{ matrix.image }} From 97c42ee1fc70836f9835ca075efcfe0d16fc1e26 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Fri, 10 Jan 2025 17:09:27 +0100 Subject: [PATCH 2/3] [ci] Remove the clicdp nightlies based CI --- .github/workflows/linux.yml | 26 -------------------------- 1 file changed, 26 deletions(-) delete mode 100644 .github/workflows/linux.yml diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml deleted file mode 100644 index 77ef221..0000000 --- a/.github/workflows/linux.yml +++ /dev/null @@ -1,26 +0,0 @@ -name: linux -on: [push, pull_request] - -jobs: - centos7: - runs-on: ubuntu-latest - strategy: - fail-fast: false - matrix: - COMPILER: [gcc11] - LCG: [104] - - steps: - - uses: actions/checkout@v3 - - uses: cvmfs-contrib/github-action-cvmfs@v3 - - uses: aidasoft/run-lcg-view@v4 - with: - view-path: "/cvmfs/clicdp.cern.ch/iLCSoft/lcg/${{ matrix.LCG }}/nightly/x86_64-centos7-${{ matrix.COMPILER }}-opt" - setup-script: "init_ilcsoft.sh" - run: | - mkdir build - cd build - cmake -GNinja -C ${ILCSOFT}/ILCSoft.cmake -DCMAKE_CXX_FLAGS=" -fdiagnostics-color=always " -DINSTALL_DOC=ON .. - ninja -k0 - ctest --output-on-failure - ninja install From fe33bc83b2b52f04a1b470fcb9a2e7c63dc4c812 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Fri, 10 Jan 2025 17:12:59 +0100 Subject: [PATCH 3/3] Fix catch-value warning to make CI pass --- source/src/DBInterface.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/src/DBInterface.cc b/source/src/DBInterface.cc index 70fce34..75e5064 100644 --- a/source/src/DBInterface.cc +++ b/source/src/DBInterface.cc @@ -831,7 +831,7 @@ namespace lccd { { condTagMgr()->createCondDBTag( tag, description ) ; } - catch ( CondDBException condbexc ) + catch ( CondDBException& condbexc ) { // std::cout << " WARNING: DBInterface::tagFolder: "<