Fix: incorrect XPath quoting (Fixes #431)

bakonyiferenc · bakonyiferenc · commit bcb80f17fa09 · 2025-12-18T06:28:12.000Z
diff --git a/sagemcom_api/client.py b/sagemcom_api/client.py
@@ -445,7 +445,7 @@ async def get_values_by_xpaths(self, xpaths, options: dict | None = None) -> dic
             {
                 "id": i,
                 "method": "getValue",
-                "xpath": urllib.parse.quote(xpath),
+                "xpath": urllib.parse.quote(xpath, "/=[]'"),
                 "options": options if options else {},
             }
             for i, xpath in enumerate(xpaths.values())
@@ -481,7 +481,7 @@ async def set_value_by_xpath(
         actions = {
             "id": 0,
             "method": "setValue",
-            "xpath": urllib.parse.quote(xpath),
+            "xpath": urllib.parse.quote(xpath, "/=[]'"),
             "parameters": {"value": str(value)},
             "options": options if options else {},
         }

Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,7 @@ async def get_values_by_xpaths(self, xpaths, options: dict \| None = None) -> dic`
`445`	`445`	`{`
`446`	`446`	`"id": i,`
`447`	`447`	`"method": "getValue",`
`448`		`- "xpath": urllib.parse.quote(xpath),`
	`448`	`+ "xpath": urllib.parse.quote(xpath, "/=[]'"),`
`449`	`449`	`"options": options if options else {},`
`450`	`450`	`}`
`451`	`451`	`for i, xpath in enumerate(xpaths.values())`
`@@ -481,7 +481,7 @@ async def set_value_by_xpath(`
`481`	`481`	`actions = {`
`482`	`482`	`"id": 0,`
`483`	`483`	`"method": "setValue",`
`484`		`- "xpath": urllib.parse.quote(xpath),`
	`484`	`+ "xpath": urllib.parse.quote(xpath, "/=[]'"),`
`485`	`485`	`"parameters": {"value": str(value)},`
`486`	`486`	`"options": options if options else {},`
`487`	`487`	`}`