From 1334c1a05219d225fc80cbe13b362cd5f601e4df Mon Sep 17 00:00:00 2001 From: David Parker Date: Tue, 28 Oct 2025 00:00:11 +0000 Subject: [PATCH 1/2] [patch] Tiny adjustment to formatting --- bin/mas-devops-notify-slack | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/mas-devops-notify-slack b/bin/mas-devops-notify-slack index 0084248a..ef4a8e36 100644 --- a/bin/mas-devops-notify-slack +++ b/bin/mas-devops-notify-slack @@ -41,7 +41,7 @@ def notifyProvisionFyre(channel: str, rc: int) -> bool: message = [ SlackUtil.buildHeader(f":glyph-ok: Your IBM DevIT Fyre OCP cluster ({name}) is ready"), SlackUtil.buildSection(f"{url}"), - SlackUtil.buildSection(f"- Username: `{username}`\n - Password: `{password}`"), + SlackUtil.buildSection(f"- Username: `{username}`\n- Password: `{password}`"), SlackUtil.buildSection(f"{toolchainLink}") ] else: From 49b99b2c180421e836280927d6af01f906d8248f Mon Sep 17 00:00:00 2001 From: David Parker Date: Tue, 28 Oct 2025 11:40:00 +0000 Subject: [PATCH 2/2] [patch] Handle env vars set to empty string --- bin/mas-devops-notify-slack | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/mas-devops-notify-slack b/bin/mas-devops-notify-slack index ef4a8e36..13ea97dc 100644 --- a/bin/mas-devops-notify-slack +++ b/bin/mas-devops-notify-slack @@ -56,9 +56,9 @@ def notifyProvisionFyre(channel: str, rc: int) -> bool: if __name__ == "__main__": # If SLACK_TOKEN or SLACK_CHANNEL env vars are not set then silently exit taking no action - SLACK_TOKEN = os.getenv("SLACK_TOKEN", None) - SLACK_CHANNEL = os.getenv("SLACK_CHANNEL", None) - if SLACK_TOKEN is None or SLACK_CHANNEL is None: + SLACK_TOKEN = os.getenv("SLACK_TOKEN", "") + SLACK_CHANNEL = os.getenv("SLACK_CHANNEL", "") + if SLACK_TOKEN == "" or SLACK_CHANNEL == "": sys.exit(0) # Initialize the properties we need