From dacb038806d55ae043ebd88c7c81f1b1a7ef9722 Mon Sep 17 00:00:00 2001
From: balnibarbian <233518869+balnibarbian@users.noreply.github.com>
Date: Sat, 17 Jan 2026 21:42:30 +0800
Subject: [PATCH] fix(metamcp): skip internal postgres config when using
 external DATABASE_URL

When users provide `env.DATABASE_URL` to use an external PostgreSQL database,
the chart should not:
- Create the wait-db init container that waits for internal postgres
- Inject internal postgres environment variables (POSTGRES_HOST, PGHOST, etc.)
- Reference the internal postgres secret

This allows users to use external databases without needing to create
dummy secrets or deal with init containers waiting for non-existent services.

Fixes the issue where `postgres.enabled: false` with external `DATABASE_URL`
still required manual workarounds.
---
 charts/metamcp/templates/deployment.yaml | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/charts/metamcp/templates/deployment.yaml b/charts/metamcp/templates/deployment.yaml
index b260696..13c7cad 100644
--- a/charts/metamcp/templates/deployment.yaml
+++ b/charts/metamcp/templates/deployment.yaml
@@ -47,7 +47,9 @@ spec:
       {{- if .Values.serviceAccount.create }}
       serviceAccountName: {{ include "metamcp.fullname" . }}
       {{- end }}
-      {{- /* always use internal postgres */}}
+      {{- $hasDBURL := and (kindIs "map" .Values.env) (hasKey .Values.env "DATABASE_URL") }}
+      {{- if not $hasDBURL }}
+      {{- /* only use init container when using internal postgres */}}
       initContainers:
         - name: wait-db
           image: {{ .Values.postgres.image }}
@@ -59,6 +61,7 @@ spec:
                 secretKeyRef:
                   name: {{ include "metamcp.postgresFullname" . }}-secret
                   key: password
+      {{- end }}
       containers:
         - name: metamcp
           image: {{ printf "%s:%s" .Values.image.repository .Values.image.tag | quote }}
@@ -86,9 +89,9 @@ spec:
                   key: BETTER_AUTH_SECRET
             {{- end }}
             {{- if not $hasDBURL }}
+            {{- /* internal postgres environment variables */}}
             - name: DATABASE_URL
               value: {{ printf "postgresql://%s:%s@%s.%s.svc.cluster.local:5432/%s?sslmode=disable" (.Values.postgres.auth.username | toString) (.Values.postgres.auth.password | toString) (include "metamcp.postgresFullname" .) .Release.Namespace (.Values.postgres.auth.database | toString) | quote }}
-            {{- end }}
             - name: POSTGRES_HOST
               value: {{ printf "%s.%s.svc.cluster.local" (include "metamcp.postgresFullname" .) .Release.Namespace | quote }}
             - name: PGHOST
@@ -111,10 +114,11 @@ spec:
                 secretKeyRef:
                   name: {{ include "metamcp.postgresFullname" . }}-secret
                   key: password
+            {{- end }}
+            {{- /* end internal postgres envs */}}
             {{- with .Values.extraEnv }}
             {{- toYaml . | nindent 12 }}
             {{- end }}
-          {{- /* end internal postgres envs */}}
           livenessProbe:
             httpGet:
               path: /health