Commit 7207eb7
Address CI codex R8 P3 on PR-A: 2020 review tuning-table API column
P3 (tuning-table API clarity): The 2020 review's Tuning Parameters
table at L263-L271 mixed conceptual paper knobs (Treatment direction,
Cluster level, Placebo lag) with real library knobs (L_max, n_bootstrap)
without distinguishing the two. Some entries described user-settable
parameters that the library does not actually expose:
- "Treatment direction" was listed as an enum knob but is inferred from
the fitted sample (joiners/leavers/both views are read off
results.joiners_* / results.leavers_*).
- "Cluster level" was listed as a column name but the library only
accepts cluster=None.
- "Placebo lag (L_pre)" was listed as an integer with default 1, but
the library exposes a boolean gate (placebo: bool = True), and Phase
1 supports only the single-lag DID_M^pl.
Rewrites the table with the same two-column "(paper concept) | Library
API" structure used in the R7 fix to the 2022 review's tuning table,
making the paper-vs-implementation correspondence explicit for every
row. The actual library surface (L_max, n_bootstrap, cluster=None,
placebo: bool, bootstrap_weights) is now documented row-by-row.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 6c468a4 commit 7207eb7
1 file changed
Lines changed: 8 additions & 7 deletions
Lines changed: 8 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
272 | 273 | | |
273 | 274 | | |
274 | 275 | | |
| |||
0 commit comments