diff --git a/NEWS b/NEWS index 07653ef6a37f..8403ce02ff2c 100644 --- a/NEWS +++ b/NEWS @@ -31,6 +31,10 @@ PHP NEWS - OpenSSL: . Fix a bunch of memory leaks and crashes on edge cases. (ndossche) +- Random: + . Fixed bug GH-21730 (Mt19937::__debugInfo() leaks state HashTable when + the serialize callback fails). (iliaal) + - SPL: . Fixed bug GH-21499 (RecursiveArrayIterator getChildren UAF after parent free). (Girgias) diff --git a/ext/random/engine_mt19937.c b/ext/random/engine_mt19937.c index 640099909103..b76e89ac1d6e 100644 --- a/ext/random/engine_mt19937.c +++ b/ext/random/engine_mt19937.c @@ -392,11 +392,11 @@ PHP_METHOD(Random_Engine_Mt19937, __debugInfo) if (engine->engine.algo->serialize) { array_init(&t); + zend_hash_str_add(Z_ARR_P(return_value), "__states", strlen("__states"), &t); if (!engine->engine.algo->serialize(engine->engine.state, Z_ARRVAL(t))) { zend_throw_exception(NULL, "Engine serialize failed", 0); RETURN_THROWS(); } - zend_hash_str_add(Z_ARR_P(return_value), "__states", strlen("__states"), &t); } } /* }}} */ diff --git a/ext/random/tests/02_engine/debuginfo_states.phpt b/ext/random/tests/02_engine/debuginfo_states.phpt new file mode 100644 index 000000000000..dacae8810513 --- /dev/null +++ b/ext/random/tests/02_engine/debuginfo_states.phpt @@ -0,0 +1,41 @@ +--TEST-- +GH-21730: __debugInfo() exposes the engine state under __states +--FILE-- +__debugInfo(); +var_dump(array_key_exists('__states', $mtInfo)); +var_dump(count($mtInfo['__states'])); + +$pcg = new PcgOneseq128XslRr64(1234); +$pcgInfo = $pcg->__debugInfo(); +var_dump(array_key_exists('__states', $pcgInfo)); +var_dump(count($pcgInfo['__states'])); + +$xo = new Xoshiro256StarStar(1234); +$xoInfo = $xo->__debugInfo(); +var_dump(array_key_exists('__states', $xoInfo)); +var_dump(count($xoInfo['__states'])); + +// The serialized form and __debugInfo both round-trip through the engine's +// serialize callback, so they must produce identical state data. +var_dump($mt->__serialize()[1] === $mtInfo['__states']); +var_dump($pcg->__serialize()[1] === $pcgInfo['__states']); +var_dump($xo->__serialize()[1] === $xoInfo['__states']); + +?> +--EXPECT-- +bool(true) +int(626) +bool(true) +int(2) +bool(true) +int(4) +bool(true) +bool(true) +bool(true)