Added test for JsonStringEnumMemberConverter, updated CHANGELOG.md, refactored ClientUtilsTest.cs

Author: lvukadinovic-ib

ApiClient.Tests/ClientUtilsTest.cs

@@ -25,12 +25,12 @@ public void ParameterToStringTest()
         var randomNumber = 5;
         var randomString = "axT3!er_hOp7&";
 
-        Assert.AreEqual(ClientUtils.ParameterToString(dateTime), "2025-12-01T15:30:45.000+00:00");
-        Assert.AreEqual(ClientUtils.ParameterToString(dateTimeOffset), "2025-12-01T15:30:45.000+00:00");
-        Assert.AreEqual(ClientUtils.ParameterToString(booleanValue), "true");
-        Assert.AreEqual(ClientUtils.ParameterToString(list), "1,2,3,4,5,6,7,8,9,10,11,12");
-        Assert.AreEqual(ClientUtils.ParameterToString(enumValue), "ALSO_OK");
-        Assert.AreEqual(ClientUtils.ParameterToString(randomNumber), "5");
-        Assert.AreEqual(ClientUtils.ParameterToString(randomString), "axT3!er_hOp7&");
+        Assert.AreEqual("2025-12-01T15:30:45.000+00:00", ClientUtils.ParameterToString(dateTime));
+        Assert.AreEqual( "2025-12-01T15:30:45.000+00:00", ClientUtils.ParameterToString(dateTimeOffset));
+        Assert.AreEqual("true", ClientUtils.ParameterToString(booleanValue));
+        Assert.AreEqual("1,2,3,4,5,6,7,8,9,10,11,12", ClientUtils.ParameterToString(list));
+        Assert.AreEqual("ALSO_OK", ClientUtils.ParameterToString(enumValue));
+        Assert.AreEqual("5", ClientUtils.ParameterToString(randomNumber));
+        Assert.AreEqual("axT3!er_hOp7&", ClientUtils.ParameterToString(randomString));
     }
 }

ApiClient.Tests/JsonStringEnumMemberConverter.cs

@@ -0,0 +1,72 @@
+using System.Runtime.Serialization;
+using System.Text.Json;
+using Infobip.Api.Client;
+
+namespace ApiClient.Tests;
+
+[TestClass]
+public class JsonStringEnumMemberConverter
+{
+    public enum TestEnum
+    {
+        [EnumMember(Value = "VALUE_A")]
+        A = 1,
+        [EnumMember(Value = "VALUE_B")]
+        B = 2,
+        C = 3
+    }
+    
+    private JsonSerializerOptions _options;
+    
+    [TestInitialize]
+    public void Setup()
+    {
+        _options = new JsonSerializerOptions();
+        _options.Converters.Add(new JsonStringEnumMemberConverter<TestEnum>());
+    }
+    
+    [TestMethod]
+    [DataRow("\"VALUE_A\"", TestEnum.A)]
+    [DataRow("\"VALUE_B\"", TestEnum.B)]
+    [DataRow("\"C\"", TestEnum.C)]
+    public void DeserializesProperValues(string json, TestEnum expected)
+    {
+        var actual = JsonSerializer.Deserialize<TestEnum>(json, _options);
+        Assert.AreEqual(expected, actual);
+    }
+
+    [TestMethod]
+    [DataRow(TestEnum.A, "\"VALUE_A\"")]
+    [DataRow(TestEnum.B, "\"VALUE_B\"")]
+    [DataRow(TestEnum.C, "\"C\"")]
+    public void Serializes_Proper_Values(TestEnum value, string expectedJson)
+    {
+        var actualJson = JsonSerializer.Serialize(value, _options);
+        Assert.AreEqual(expectedJson, actualJson);
+    }
+
+    [TestMethod]
+    public void Deserializes_Ignores_Case()
+    {
+        var actual = JsonSerializer.Deserialize<TestEnum>("\"value_b\"", _options);
+        Assert.AreEqual(TestEnum.B, actual);
+    }
+
+    [TestMethod]
+    public void Deserializes_Throws_On_Unknown_Value()
+    {
+        Assert.ThrowsExactly<JsonException>(() =>
+        {
+            JsonSerializer.Deserialize<TestEnum>("\"does_not_exist\"", _options);
+        });
+    }
+
+    [TestMethod]
+    public void Deserializes_Throws_On_NonString()
+    {
+        Assert.ThrowsExactly<JsonException>(() =>
+        {
+            JsonSerializer.Deserialize<TestEnum>("123", _options);
+        });
+    }
+}

CHANGELOG.md

@@ -8,10 +8,13 @@ and this library adheres to [Semantic Versioning](http://semver.org/) as mention
 ## [ [4.0.2](https://github.com/infobip/infobip-api-csharp-client/releases/tag/v4.0.2) ] - 2025-12-08
 
 ### Added
-- Custom Enum Converter for System.Text.Json (see ###fixed for more information)
+- Custom Enum Converter for System.Text.Json (see ###fixed for more information).
+
+### Changed
+- Refactored tests: removed unused code, aligned some variable naming, removed unused imports.
 
 ### Fixed
-- Enum deserialization using System.Text.Json now correctly maps Json string values to enums using values defined by [EnumMember]
+- Enum deserialization using System.Text.Json now correctly maps Json string values to enums using values defined by [EnumMember].
 
 ## [ [4.0.1](https://github.com/infobip/infobip-api-csharp-client/releases/tag/v4.0.1) ] - 2025-12-03
 

src/Infobip.Api.Client/Client/JsonStringEnumMemberConverter.cs

@@ -7,11 +7,21 @@
 
 namespace Infobip.Api.Client
 {
+
+    /// <summary>
+    ///     System.Text.Json converter that serializes and deserializes enums using their <see cref="EnumMemberAttribute"/> values if present, else their names.
+    ///     Ensures proper enum (de)serialization for API models where JSON uses string values defined by <see cref="EnumMemberAttribute"/>.
+    /// </summary>
+    /// <typeparam name="T">Enum type to convert.</typeparam>
     public class JsonStringEnumMemberConverter<T> : JsonConverter<T> where T : struct, Enum
     {
         private readonly Dictionary<string, T> _fromValue;
         private readonly Dictionary<T, string> _toValue;
 
+        /// <summary>
+        ///     Initializes a new instance of <see cref="JsonStringEnumMemberConverter{T}"/>.
+        ///     Builds internal mappings of enum values to their <see cref="EnumMemberAttribute"/> strings.
+        /// </summary>
         public JsonStringEnumMemberConverter()
         {
             _fromValue = new Dictionary<string, T>(StringComparer.OrdinalIgnoreCase);
@@ -26,6 +36,15 @@ public JsonStringEnumMemberConverter()
             }
         }
 
+        /// <summary>
+        ///     Reads and converts the JSON string value to the corresponding enum value,
+        ///     interpreting <see cref="EnumMemberAttribute.Value"/> if present.
+        /// </summary>
+        /// <param name="reader">The reader to read from.</param>
+        /// <param name="typeToConvert">The type being converted.</param>
+        /// <param name="options">Serialization options to use.</param>
+        /// <returns>The converted enum value.</returns>
+        /// <exception cref="JsonException">Thrown if JSON token is not a string or cannot be mapped to enum.</exception>
         public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             if (reader.TokenType == JsonTokenType.String)
@@ -38,6 +57,12 @@ public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerial
             throw new JsonException($"Unexpected token parsing enum. Expected String, got {reader.TokenType}.");
         }
 
+        /// <summary>
+        ///     Writes the enum value as a JSON string, preferring the <see cref="EnumMemberAttribute.Value"/> if present.
+        /// </summary>
+        /// <param name="writer">The writer to write to.</param>
+        /// <param name="value">The enum value to write.</param>
+        /// <param name="options">Serialization options to use.</param>
         public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
         {
             if (_toValue.TryGetValue(value, out var stringValue))