Skip to content

Commit 93e33b1

Browse files
Refactored tests a bit.
1 parent 82f074c commit 93e33b1

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

ApiClient.Tests/Api/ApiTest.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
using System.Reflection;
33
using System.Runtime.Serialization;
44
using Infobip.Api.Client;
5-
using Microsoft.VisualStudio.TestTools.UnitTesting;
65
using WireMock.Matchers;
76
using WireMock.RequestBuilders;
87
using WireMock.ResponseBuilders;
@@ -200,9 +199,9 @@ protected void SetUpMultipartFormRequest(string url, Multimap<string, string> gi
200199
req.WithBody(body =>
201200
{
202201
var allKeysFound = givenParts.All(kvp =>
203-
body.Contains($"name={kvp.Key}", StringComparison.InvariantCultureIgnoreCase));
202+
body!.Contains($"name={kvp.Key}", StringComparison.InvariantCultureIgnoreCase));
204203
var allValuesFound = givenParts.All(kvp =>
205-
kvp.Value.All(value => body.Contains(value, StringComparison.InvariantCultureIgnoreCase)));
204+
kvp.Value.All(value => body!.Contains(value, StringComparison.InvariantCultureIgnoreCase)));
206205
return allValuesFound && allKeysFound;
207206
});
208207

ApiClient.Tests/Api/EmailApiTest.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using Infobip.Api.Client.Api;
55
using Infobip.Api.Client.Client;
66
using Infobip.Api.Client.Model;
7-
using Microsoft.VisualStudio.TestTools.UnitTesting;
87
using Newtonsoft.Json;
98
using static Infobip.Api.Client.Model.EmailAddDomainRequest;
109
using JsonSerializer = System.Text.Json.JsonSerializer;
@@ -1879,7 +1878,7 @@ public void ShouldUnassignIpPoolFromDomain()
18791878
emailApi.RemoveIpPoolFromDomainWithHttpInfoAsync(givenDomainId, givenPoolId).Result, 204);
18801879
}
18811880

1882-
[DataTestMethod]
1881+
[TestMethod]
18831882
[DataRow(0)]
18841883
[DataRow(1)]
18851884
public void SendEmailErrorResponseTest(int errorResponseIndex)
@@ -2136,7 +2135,7 @@ void AssertEmailWebhookTrackResponse(EmailWebhookTrackResponse emailWebhookTrack
21362135
}
21372136
}
21382137

2139-
[DataTestMethod]
2138+
[TestMethod]
21402139
[DataRow(0)]
21412140
[DataRow(1)]
21422141
public void GetEmailDeliveryReportsResponseTest(int errorResponseIndex)

ApiClient.Tests/ApiExceptionTest.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
using ApiClient.Tests.Api;
22
using Infobip.Api.Client.Api;
33
using Infobip.Api.Client.Model;
4-
using Microsoft.VisualStudio.TestTools.UnitTesting;
54
using ApiException = Infobip.Api.Client.ApiException;
65

76
namespace ApiClient.Tests;
@@ -23,7 +22,7 @@ public class ApiExceptionTest : ApiTest
2322
Tuple.Create(503, "0", "Service Unavailable", "Error processing email validation request! Please try again")
2423
};
2524

26-
[DataTestMethod]
25+
[TestMethod]
2726
[DataRow(0)]
2827
[DataRow(1)]
2928
[DataRow(2)]

ApiClient.Tests/DateTimeSerializationTest.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using Microsoft.VisualStudio.TestTools.UnitTesting;
2-
using Newtonsoft.Json;
1+
using Newtonsoft.Json;
32

43
namespace ApiClient.Tests;
54

@@ -33,7 +32,7 @@ public class DateTimeSerializationTest
3332
[DataRow("2035-08-18T10:38:42.777-0130", 6)]
3433
[DataRow("2035-08-18T17:38:42.777+0530", 7)]
3534
[DataRow("2035-08-18T06:38:42.777-0530", 8)]
36-
[DataTestMethod]
35+
[TestMethod]
3736
public void DateTimeFormatDeserializationTest(string dateString, int dateValueIndex)
3837
{
3938
var expected = DateTimeValues[dateValueIndex];
@@ -60,7 +59,7 @@ public void DateTimeFormatDeserializationTest(string dateString, int dateValueIn
6059
[DataRow(6, "2035-08-18T10:38:42.777-01:30")]
6160
[DataRow(7, "2035-08-18T17:38:42.777+05:30")]
6261
[DataRow(8, "2035-08-18T06:38:42.777-05:30")]
63-
[DataTestMethod]
62+
[TestMethod]
6463
public void DateTimeFormatSerializationTest(int dateValueIndex, string expected)
6564
{
6665
var initialDate = DateTimeValues[dateValueIndex];

0 commit comments

Comments
 (0)