Closes #1495 - improve the behavior when agent commands fail (or are not available) due to missing configuration - backend (#1527)

* DynamicallyActivatableServiceObserver is going ood

* Improve behavior in the UI when agent commands fail (for log-preloading)

* Improve behavior in the UI when agent commands fail (for downloading support archive)

* Fixing HttpPropertySourceStateTest

* Fixing checkMap Test

* Fixing DASObserver Test as well as implementing requests from the review

* Fixing HttpPropertySourceStateTest

* Trying to fix eslint test

* Trying to fix eslint test #2

* Fixing eslint test #3

Co-authored-by: Priebe Daniel <dpr@novatec-gmbh.de>

Author: danipaniii

components/inspectit-ocelot-configurationserver-ui/.eslintrc

@@ -46,6 +46,7 @@
         "import/first": "error",
         "import/no-useless-path-segments": "error",
         "react/prop-types": "warn",
-        "prettier/prettier": ["error", { "endOfLine": "auto" }]
+        "prettier/prettier": ["error", { "endOfLine": "auto" }],
+        "react/no-unknown-property": ["error", { "ignore": ["jsx", "global", "align"] }]
     }
 }

components/inspectit-ocelot-configurationserver-ui/.yarn/install-state.gz

@@ -0,0 +1 @@
+nodeLinker: node-modules

components/inspectit-ocelot-configurationserver-ui/.yarnrc.yml

@@ -114,7 +114,8 @@ class StatusTable extends React.Component {
     const { agentVersion } = metaInformation;
 
     const agentVersionTokens = agentVersion.split('.');
-    let logAvailable = true;
+    let logAvailable = false;
+    let agentCommandsEnabled = false;
     if (agentVersionTokens.length == 2 || agentVersionTokens.length == 3) {
       const agentVersionNumber =
         agentVersionTokens[0] * 10000 + agentVersionTokens[1] * 100 + (agentVersionTokens.length == 3 ? agentVersionTokens[2] * 1 : 0);
@@ -130,6 +131,10 @@ class StatusTable extends React.Component {
       }
       agentId = metaInformation.agentId;
       agentIdElement = <span style={{ color: 'gray' }}>({agentId})</span>;
+
+      let settingStates = JSON.parse(metaInformation.settingStates);
+      logAvailable = settingStates.LogPreloader;
+      agentCommandsEnabled = settingStates.AgentCommandService;
     }
     return (
       <div className="this">
@@ -181,15 +186,18 @@ class StatusTable extends React.Component {
           tooltip="Show Configuration"
           tooltipOptions={{ showDelay: 500 }}
         />
-        {logAvailable && (
-          <Button
-            className="log-button"
-            icon="pi pi-align-justify"
-            onClick={() => onShowDownloadDialog(agentId, attributes, 'log')}
-            tooltip="Show Logs"
-            tooltipOptions={{ showDelay: 500 }}
-          />
-        )}
+        <Button
+          className="log-button"
+          icon="pi pi-align-justify"
+          onClick={() => onShowDownloadDialog(agentId, attributes, 'log')}
+          tooltip={
+            logAvailable && agentCommandsEnabled
+              ? 'Show Logs'
+              : "Please enable 'log-preloading' and 'agent-commands' in the config! Make sure to pass the right url for the agent commands!"
+          }
+          tooltipOptions={{ showDelay: 500 }}
+          disabled={!logAvailable || !agentCommandsEnabled}
+        />
       </div>
     );
   };
@@ -226,6 +234,9 @@ class StatusTable extends React.Component {
     const { onShowDownloadDialog } = this.props;
     const { health, metaInformation } = rowData;
 
+    let settingStates = JSON.parse(metaInformation.settingStates);
+    let agentCommandsEnabled = settingStates.AgentCommandService;
+
     let healthInfo;
     let iconClass;
     let iconColor;
@@ -273,8 +284,13 @@ class StatusTable extends React.Component {
               className="archive-button"
               icon="pi pi-cloud-download"
               onClick={() => onShowDownloadDialog(metaInformation.agentId, metaInformation.agentVersion, 'archive')}
-              tooltip="Download Support Archive"
+              tooltip={
+                agentCommandsEnabled
+                  ? 'Download Support Archive'
+                  : "Make sure to enabled 'agent-commands' in the config and set the right URL!"
+              }
               tooltipOptions={{ showDelay: 500 }}
+              disabled={!agentCommandsEnabled}
             />
           </div>
         ) : (