feat:Modified internal span filtering logic according to new span-filtering mechanism

Signed-off-by: Cagri Yonca <cagri@ibm.com>

Author: CagriYonca

src/instana/agent/host.py

@@ -399,14 +399,20 @@ def __is_endpoint_ignored(self, span_attributes: dict) -> bool:
             return False
 
         # Check include rules
-        for rule in filters.get("include", [{}]):
-            if matches_rule(rule.get("attributes", []), span_attributes):
-                return False
+        include_rules = filters.get("include", [])
+        if any(
+            matches_rule(rule.get("attributes", []), span_attributes)
+            for rule in include_rules
+        ):
+            return False
 
         # Check exclude rules
-        for rule in filters.get("exclude", [{}]):
-            if matches_rule(rule.get("attributes", []), span_attributes):
-                return True
+        exclude_rules = filters.get("exclude", [])
+        if any(
+            matches_rule(rule.get("attributes", []), span_attributes)
+            for rule in exclude_rules
+        ):
+            return True
 
         return False
 

src/instana/instrumentation/urllib3.py

@@ -94,23 +94,7 @@ def urlopen_with_instana(
         tracer, parent_span, span_name = get_tracer_tuple()
 
         # If we're not tracing, just return; boto3 has it's own visibility
-        # Also, skip creating spans for internal Instana calls when
-        # 'com.instana' appears in either the full URL, the path argument,
-        # or the connection host.
-        request_url_or_path = (
-            kwargs.get("request_url")
-            or kwargs.get("url")
-            or (args[1] if len(args) >= 2 else "")
-            or ""
-        )
-        host = getattr(instance, "host", "") or ""
-
-        if (
-            not tracer
-            or span_name == "boto3"
-            or "com.instana" in request_url_or_path
-            or "com.instana" in host
-        ):
+        if not tracer or span_name == "boto3":
             return wrapped(*args, **kwargs)
 
         parent_context = parent_span.get_span_context() if parent_span else None

src/instana/options.py

@@ -134,6 +134,36 @@ def set_trace_configurations(self) -> None:
 
         self.set_disable_trace_configurations()
         self.set_stack_trace_configurations()
+        if "INSTANA_ALLOW_INTERNAL_SPANS" not in os.environ:
+            self.add_internal_span_filter()
+
+    def add_internal_span_filter(self) -> None:
+        if "exclude" not in self.span_filters:
+            self.span_filters["exclude"] = []
+        self.span_filters["exclude"].extend(
+            [
+                {
+                    "name": "filter-internal-spans-by-url",
+                    "attributes": [
+                        {
+                            "key": "http.url",
+                            "values": ["com.instana"],
+                            "match_type": "contains",
+                        }
+                    ],
+                },
+                {
+                    "name": "filter-internal-spans-by-host",
+                    "attributes": [
+                        {
+                            "key": "http.host",
+                            "values": ["com.instana"],
+                            "match_type": "contains",
+                        }
+                    ],
+                },
+            ]
+        )
 
     def _apply_env_stack_trace_config(self) -> None:
         """Apply stack trace configuration from environment variables."""

tests/clients/test_urllib3.py

@@ -1006,12 +1006,15 @@ def test_internal_span_creation_with_url_in_hostname(self) -> None:
 
         spans = self.recorder.queued_spans()
 
-        assert len(spans) == 1
+        assert len(spans) == 2
+
+        filtered_spans = agent.filter_spans(spans)
+        assert len(filtered_spans) == 1
 
-        test_span = spans[0]
+        test_span = filtered_spans[0]
         assert test_span.data["sdk"]["name"] == "test"
 
-        urllib3_spans = [span for span in spans if span.n == "urllib3"]
+        urllib3_spans = [span for span in filtered_spans if span.n == "urllib3"]
         assert len(urllib3_spans) == 0
 
     def test_internal_span_creation_with_url_in_path(self) -> None:
@@ -1024,11 +1027,13 @@ def test_internal_span_creation_with_url_in_path(self) -> None:
                 pass
 
         spans = self.recorder.queued_spans()
+        assert len(spans) == 2
 
-        assert len(spans) == 1
+        filtered_spans = agent.filter_spans(spans)
+        assert len(filtered_spans) == 1
 
-        test_span = spans[0]
+        test_span = filtered_spans[0]
         assert test_span.data["sdk"]["name"] == "test"
 
-        urllib3_spans = [span for span in spans if span.n == "urllib3"]
+        urllib3_spans = [span for span in filtered_spans if span.n == "urllib3"]
         assert len(urllib3_spans) == 0

tests/test_options.py

@@ -23,6 +23,7 @@ class TestBaseOptions:
     @pytest.fixture(autouse=True)
     def _resource(self) -> Generator[None, None, None]:
         self.base_options = None
+        os.environ["INSTANA_ALLOW_INTERNAL_SPANS"] = "True"
         yield
         if "tracing" in config.keys():
             del config["tracing"]