Improve from static analysis results

Author: schmengler

src/TimerEvent.php

@@ -39,13 +39,22 @@ private function asArray()
 
     public function asCsvLine(): string
     {
-        $f = fopen('php://memory', 'rb+');
-        if (fputcsv($f, $this->asArray()) === false) {
-            throw new \RuntimeException('Cannot format TimerEvent as CSV');
+        $csvStream = fopen('php://memory', 'rb+');
+        if ($csvStream === false) {
+            throw new \RuntimeException('Could not open temporary stream');
+        }
+        try {
+            if (fputcsv($csvStream, $this->asArray()) === false) {
+                throw new \RuntimeException('Could not format TimerEvent as CSV');
+            }
+            rewind($csvStream);
+            $line = stream_get_contents($csvStream);
+            if ($line === false) {
+                throw new \RuntimeException('Could not read from temporary CSV stream');
+            }
+        } finally {
+            fclose($csvStream);
         }
-        rewind($f);
-        $line = stream_get_contents($f);
-        fclose($f);
         return rtrim($line);
     }
-}
+}

tests/RecipeTest.php

@@ -52,19 +52,22 @@ public function testTimerWithCsvResult()
             $output,
             'Test task should be executed.' . "\n" .
             'Expected "Test Output"' . "\n" .
-            'Actual Output: ' . print_r($output,true)
+            'Actual Output: ' . print_r($output, true)
         );
         $this->assertRegExp(<<<'REGEX'
 {BEGIN,test,[\d.]+,[\d.]+
 END,test,[\d.]+,[\d.]+}
 REGEX
 
-            , file_get_contents($csvFile), 'CSV file should be written with timer results');
+            , (string)file_get_contents($csvFile), 'CSV file should be written with timer results');
     }
 
     private function createTmpFile()
     {
         $fileName = tempnam(sys_get_temp_dir(), 'integer-net-deployer-timer');
+        if (!$fileName) {
+            throw new \RuntimeException('Could not create temporary file');
+        }
         $this->tmpFiles[] = $fileName;
         return $fileName;
     }