Fix ineffassign lint errors

Fix "err" usage in unit tests and other code to check each error
where it happens instead of combining errors for broader unit test
failure checks.

Author: killianmuldoon

cmd/tas-policy-controller/main.go

@@ -37,6 +37,9 @@ func main() {
 		panic(err)
 	}
 	syncDuration, err := time.ParseDuration(syncPeriod)
+	if err != nil {
+		panic(err)
+	}
 	metricsClient := metrics.NewClient(clientConfig)
 	telpolicyClient, _, err := telemetrypolicyclient.NewRest(*clientConfig)
 	if err != nil {

pkg/cache/autoupdating_test.go

@@ -177,6 +177,9 @@ func TestNodeMetricsCache_WriteMetric(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			err := tt.n.WriteMetric(tt.args.metricName, nil)
+			if err == nil && tt.errorExpected {
+				t.Fail()
+			}
 			_, err = tt.n.ReadMetric(tt.queriedMetric)
 			if err == nil && tt.errorExpected {
 				t.Fail()

pkg/metrics/client_test.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"io/ioutil"
 	"k8s.io/client-go/tools/clientcmd"
+	"log"
 	"reflect"
 	"testing"
 	"time"
@@ -38,6 +39,9 @@ func dummyRestClientConfig() *restclient.Config {
 	fallbackReader := bytes.NewBuffer([]byte{})
 	clientConfig := clientcmd.NewInteractiveDeferredLoadingClientConfig(loadingRules, overrides, fallbackReader)
 	restConfig, err := clientConfig.ClientConfig()
+	if err == nil {
+		log.Fatalf("Can't create dummy rest client config %v ", err)
+	}
 	return restConfig
 }
 

pkg/scheduler/scheduler_test.go

@@ -111,6 +111,10 @@ func TestMetricsExtender_prescheduleChecks(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			m := NewMetricsExtender(tt.fields.cache)
 			err := tt.fields.cache.WritePolicy(tt.fields.policy.Namespace, tt.fields.policy.Name, tt.fields.policy)
+			if err != nil && tt.wantErr {
+				log.Print(err)
+				return
+			}
 			argsAsJSON, err := json.Marshal(tt.prioritizeArgs)
 			if err != nil && tt.wantErr {
 				log.Print(err)
@@ -194,6 +198,10 @@ func TestMetricsExtender_Prioritize(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			m := NewMetricsExtender(tt.fields.cache)
 			err := tt.fields.cache.WritePolicy(tt.fields.policy.Namespace, tt.fields.policy.Name, tt.fields.policy)
+			if err != nil && tt.wantErr {
+				log.Print(err)
+				return
+			}
 			argsAsJSON, err := json.Marshal(tt.prioritizeArgs)
 			if err != nil && tt.wantErr {
 				log.Print(err)
@@ -283,7 +291,15 @@ func TestMetricsExtender_Filter(t *testing.T) {
 				cache: tt.fields.cache,
 			}
 			err := tt.fields.cache.WritePolicy(tt.fields.policy.Namespace, tt.fields.policy.Name, tt.fields.policy)
+			if err != nil && tt.wantErr {
+				log.Print(err)
+				return
+			}
 			err = tt.fields.cache.WriteMetric(tt.fields.policy.Spec.Strategies["dontschedule"].Rules[0].Metricname, tt.args.metric)
+			if err != nil && tt.wantErr {
+				log.Print(err)
+				return
+			}
 			argsAsJSON, err := json.Marshal(twoNodeArgument)
 			if err != nil {
 				log.Print(err)