-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(tokens): add gray colors #30799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thetaPC
wants to merge
85
commits into
ionic-modular
Choose a base branch
from
FW-6751
base: ionic-modular
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,488
−762
Draft
Changes from 16 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
3192b29
feat(tokens): add gray colors
thetaPC 0cc323a
refactor(tokens): remove comment
thetaPC d4a05e5
feat(tokens): add gray colors for dark
thetaPC 444c56a
feat(action-sheet): replace stepped variables with gray
thetaPC 0b4b461
refactor(action-sheet): revert disabled
thetaPC 6c31996
feat(alert): use gray tokens
thetaPC 15870a9
feat(card): use gray tokens
thetaPC 3902e5d
feat(checkbox): use gray tokens
thetaPC db67416
feat(datetime): use gray tokens
thetaPC fc40c77
feat(core): update dark tokens
thetaPC 9b0782c
feat(tokens): update md and add default primitives
thetaPC 50998a3
feat(tokens): use gray on datetime
thetaPC 44aa9e8
refactor(token): remove comments
thetaPC 42a1ecd
chore(themes): update gray tokens
thetaPC e20c7c0
fix(dark): use correct hex order
thetaPC c0b9385
feat(breadcrumb): use gray tokens
thetaPC 1ac2ba8
feat(datetime-button): use gray tokens
thetaPC fdefbe6
feat(ionic): use gray token for separator color
thetaPC 10d1e63
feat(infinite-scroll-content): use gray token
thetaPC 2637605
feat(input): use gray tokens
thetaPC 73b9b4f
feat(input-otp): use gray tokens
thetaPC 5e5e883
feat(item, item-divider, list-header): use gray tokens
thetaPC e979f0e
feat(label): use gray tokens
thetaPC 9b2adaa
feat(loading): use gray tokens
thetaPC 46dd76c
feat(modal): use gray tokens
thetaPC eda4918
feat(note): use gray tokens
thetaPC a4cabf8
feat(note): use gray tokens
thetaPC f330164
feat(picker): use gray tokens
thetaPC 52b7eda
feat(popover): use gray tokens
thetaPC 7a53b6d
feat(progress-bar): use gray tokens
thetaPC 98df565
feat(radio-group): use gray tokens
thetaPC 048a263
feat(range): use gray tokens
thetaPC c9cddad
feat(refresher): use gray tokens
thetaPC 826a7e4
feat(searchbar): use gray tokens
thetaPC 16a10dd
feat(segment-button): use gray tokens
thetaPC 307afa1
feat(select): use gray tokens
thetaPC cedab14
feat(textarea): use gray tokens
thetaPC 1fae450
feat(toast): use gray tokens
thetaPC 6ea3c81
feat(toggle): use gray tokens
thetaPC 5be9526
feat(ionic-swiper): use gray tokens
thetaPC e692469
refactor(angular): remove step tokens
thetaPC fb011cc
refactor(steps): update test page
thetaPC 527af98
feat(many): use gray tokens
thetaPC 8149f95
test(steps): revert removal
thetaPC a51ea42
Merge branch 'ionic-modular' of github.com:ionic-team/ionic-framework…
thetaPC 10e091b
chore(steps): run lint
thetaPC 16f91ab
feat(many): use text color tokens
thetaPC ec0bf01
chore(scripts): revert
thetaPC 00448f6
docs(scripts): add todo
thetaPC c3345d1
test(alert): remove only
thetaPC 10eac37
fix(alert): use correct variable
thetaPC 70a1892
test(toast): remove only
thetaPC 71fff87
refactor(datetime): cleaner Sass variable
thetaPC a884809
chore(toast): revert
thetaPC 161b46a
feat(many): remove last bit of steps
thetaPC eb3c5a9
test(toast): skip high constrast for now
thetaPC 383d24c
chore(many): run lint
thetaPC 0ce2e76
test(theme): update tests
thetaPC 4b149a9
fix(item): remove wrong var setup
thetaPC a193f0d
feat(light): add action sheet button bg selected fallback
thetaPC 08e8349
feat(toolbar): use components variable
thetaPC b243e73
chore(toolbar): revert
thetaPC d1c5da7
fix(toolbar): use correct color for md
thetaPC c53560e
refactor(themes): clean up colors
thetaPC ee1d755
refactor(themes): remove colors usage before initiating
thetaPC 5732df1
fix(toolbar): add bg for md light
thetaPC 75da67f
fix(toolbar): use correct colors on activated buttons
thetaPC 4652c37
test(set-content): use customTheme for palettes
thetaPC 91d4483
refactor(many): use Sass variables again
thetaPC 968782a
chore(thene): run lint
thetaPC f0ee0b3
docs(set-content): add comment
thetaPC 86972ec
test(toolbar): remove only
thetaPC cecc2a8
test(toolbar): update screenshots
thetaPC a926cd5
fix(toolbar): use correct setup
thetaPC 8af89c3
test(toolbar): remove only
thetaPC f0de6e0
fix(tab-bar): use correct colors
thetaPC 0f4d7aa
test(tab-bar): update snapshots
thetaPC fc94a0a
fix(tab-bar): use PascalCase
thetaPC 729566f
test(tab-bar): use container
thetaPC 7db9e9c
test(tab-bar): lessen container padding
thetaPC 4586638
test(modal, scripts): use config palette in scripts
thetaPC 6fe4734
chore(): add updated snapshots
Ionitron cd4f3fd
chore(): add updated snapshots
Ionitron d299976
refactor(many): add back Sass variables
thetaPC b36d02d
Merge branch 'FW-6751' of github.com:ionic-team/ionic-framework into …
thetaPC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { generateColorSteps } from '../../utils/theme'; | ||
|
|
||
| // TODO: ADD TYPE | ||
| export const darkPrimitiveColors = { | ||
| // TODO: Update hex values to use the text color variable and background color variable | ||
| gray: generateColorSteps('#ffffff', '#000', true), | ||
|
||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created this file so these colors can be exported to
iOSsinceiOSuses the same gray colors. I didn't think we needed duplicate code (one for base and one for iOS) when the colors are the same.