Make test for user non-existence more robust

[chriscohen]

On my test suite it's going through checking if users already exist before creating them, but it's getting a false positive and failing to create a user that doesn't exist.

DrushTestUserManager::createUser() doesn't have a very robust check on the drush output, which I think might be causing this.

Here's the output of my drush command which is causing the false positive.

exception 'Drush\User\UserListException' with message 'Unable to find a matching user for test.news.editor.'  [error]
in /home/vagrant/.composer/vendor/drush/drush/lib/Drush/User/UserList.php:117
Stack trace:
#0 /home/vagrant/.composer/vendor/drush/drush/lib/Drush/User/UserList.php(15):
Drush\User\UserList::getFromParameters('test.news.edito...')
#1 /home/vagrant/.composer/vendor/drush/drush/commands/user/user.drush.inc(248):
Drush\User\UserList->__construct('test.news.edito...')
#2 [internal function]: drush_user_information('test.news.edito...')
#3 /home/vagrant/.composer/vendor/drush/drush/includes/command.inc(359):
call_user_func_array('drush_user_info...', Array)
#4 /home/vagrant/.composer/vendor/drush/drush/includes/command.inc(210): _drush_invoke_hooks(Array, Array)
#5 [internal function]: drush_command('test.news.edito...')
#6 /home/vagrant/.composer/vendor/drush/drush/includes/command.inc(178): call_user_func_array('drush_command',
Array)
#7 /home/vagrant/.composer/vendor/drush/drush/lib/Drush/Boot/DrupalBoot.php(46): drush_dispatch(Array)
#8 /home/vagrant/.composer/vendor/drush/drush/drush.php(76): Drush\Boot\DrupalBoot->bootstrap_and_dispatch()
#9 /home/vagrant/.composer/vendor/drush/drush/drush.php(16): drush_main()
#10 {main}

[pfaocle]

Looks like Drush 7.x responds with a different message to 6.x:

 giblet in ~/temp/drush
± |master ✓| → grep -Ra2ni "Could not find a uid for the search term" .

 giblet in ~/temp/drush
± |master ✓| → grep -Ra2ni "Unable to find a matching user" . | wc -l
      33

 giblet in ~/temp/drush
± |master ✓| → git checkout 6.x
Switched to branch '6.x'
Your branch is up-to-date with 'origin/6.x'.

 giblet in ~/temp/drush
± |6.x ✓| → grep -Ra2ni "Unable to find a matching user" . | wc -l
       0

 giblet in ~/temp/drush
± |6.x ✓| → grep -Ra2ni "Could not find a uid for the search term" .
./commands/user/user.drush.inc-621-  switch (count($uids)) {
./commands/user/user.drush.inc-622-    case 0:
./commands/user/user.drush.inc:623:      return drush_set_error("Could not find a uid for the search term '" . $search . "'!");
./commands/user/user.drush.inc-624-      break;
./commands/user/user.drush.inc-625-    case 1:

Please test with a3a2734 which hopefully makes this a bit more robust by using the JSON formatted response from Drush and attempting to validate it a little (e.g. by checking the issued username vs. the response).

[chriscohen]

The creation of users works but I'm getting an error as follows:

User 'test.read.only' already exists on @haringeygovuk.vagrant.remote, skipping.
  Trying to create test user 'test.Authenticated' on '@haringeygovuk.vagrant.remote'.
  drush -y '@haringeygovuk.vagrant.remote' user-information 'test.Authenticated' --format=json



  [Codeception\Exception\Module]                                                                                 
  (Exception in Drupal\UserRegistry\DrushTestUserManager) Drush returned a user but the username did not match.  



Exception trace:
 () at /home/chriscohen/tests/haringey/vendor/pfaocle/codeception-module-drupal-user-registry/src/Drupal/UserRegistry/DrushTestUserManager.php:145
 Codeception\Module\Drupal\UserRegistry\DrushTestUserManager->userExists() at /home/chriscohen/tests/haringey/vendor/pfaocle/codeception-module-drupal-user-registry/src/Drupal/UserRegistry/DrushTestUserManager.php:51
 Codeception\Module\Drupal\UserRegistry\DrushTestUserManager->createUser() at /home/chriscohen/tests/haringey/vendor/pfaocle/codeception-module-drupal-user-registry/src/Drupal/UserRegistry/DrushTestUserManager.php:89
 Codeception\Module\Drupal\UserRegistry\DrushTestUserManager->createUsers() at /home/chriscohen/tests/haringey/vendor/pfaocle/codeception-module-drupal-user-registry/src/DrupalUserRegistry.php:208
 Codeception\Module\DrupalUserRegistry->manageTestUsers() at /home/chriscohen/tests/haringey/vendor/pfaocle/codeception-module-drupal-user-registry/src/DrupalUserRegistry.php:171
 Codeception\Module\DrupalUserRegistry->_beforeSuite() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/src/Codeception/Subscriber/Module.php:32
 Codeception\Subscriber\Module->beforeSuite() at n/a:n/a
 call_user_func() at /home/chriscohen/tests/haringey/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php:164
 Symfony\Component\EventDispatcher\EventDispatcher->doDispatch() at /home/chriscohen/tests/haringey/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php:53
 Symfony\Component\EventDispatcher\EventDispatcher->dispatch() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/src/Codeception/SuiteManager.php:152
 Codeception\SuiteManager->run() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/src/Codeception/Codecept.php:151
 Codeception\Codecept->runSuite() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/src/Codeception/Codecept.php:134
 Codeception\Codecept->run() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/src/Codeception/Command/Run.php:191
 Codeception\Command\Run->execute() at /home/chriscohen/tests/haringey/vendor/symfony/console/Symfony/Component/Console/Command/Command.php:252
 Symfony\Component\Console\Command\Command->run() at /home/chriscohen/tests/haringey/vendor/symfony/console/Symfony/Component/Console/Application.php:874
 Symfony\Component\Console\Application->doRunCommand() at /home/chriscohen/tests/haringey/vendor/symfony/console/Symfony/Component/Console/Application.php:195
 Symfony\Component\Console\Application->doRun() at /home/chriscohen/tests/haringey/vendor/symfony/console/Symfony/Component/Console/Application.php:126
 Symfony\Component\Console\Application->run() at /home/chriscohen/tests/haringey/vendor/codeception/codeception/codecept:27

[dustinleblanc]

Getting similar verbose debugging output but things seem to run okay:

exception 'Drush\User\UserListException' with message 'Unable to find[error]
a matching user for test.administrator.' in
/Users/dustin/.composer/vendor/drush/drush/lib/Drush/User/UserList.php:114
Stack trace:
#0
/Users/dustin/.composer/vendor/drush/drush/lib/Drush/User/UserList.php(15):
Drush\User\UserList::getFromParameters('test.administra...')
#1
/Users/dustin/.composer/vendor/drush/drush/commands/user/user.drush.inc(253):
Drush\User\UserList->__construct('test.administra...')
#2 [internal function]: drush_user_information('test.administra...')
#3
/Users/dustin/.composer/vendor/drush/drush/includes/command.inc(368):
call_user_func_array('drush_user_info...', Array)
#4
/Users/dustin/.composer/vendor/drush/drush/includes/command.inc(219):
_drush_invoke_hooks(Array, Array)
#5 [internal function]: drush_command('test.administra...')
#6
/Users/dustin/.composer/vendor/drush/drush/includes/command.inc(187):
call_user_func_array('drush_command', Array)
#7
/Users/dustin/.composer/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(62):
drush_dispatch(Array)
#8 /Users/dustin/.composer/vendor/drush/drush/drush.php(70):
Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#9 /Users/dustin/.composer/vendor/drush/drush/drush.php(11):
drush_main()
#10 {main}
Creating test user 'test.administrator' on @litehouse_local.test.
Added role administrator role to test.administrator                  [success]

Thanks for the great module!

[dustinleblanc]

Circling back on this issue @pfaocle @chriscohen; I am using this module for testing a Drupal 8 site and its working great, I'd like to quiet down the noisy output, any ideas on where to attack that?

Thanks!