fix: add more parameters to config command

Author: sangjanai

engine/common/api_server_configuration.h

@@ -97,6 +97,16 @@ static const std::unordered_map<std::string, ApiConfigurationMetadata>
                                   .accept_value = "string",
                                   .default_value = "",
                                   .allow_empty = true}},
+        {"api_server_host", ApiConfigurationMetadata{.name = "api_server_host",
+                                                     .desc = "API server host",
+                                                     .group = "Server setup",
+                                                     .accept_value = "string",
+                                                     .default_value = ""}},
+        {"api_server_port", ApiConfigurationMetadata{.name = "api_server_port",
+                                                     .desc = "API server port",
+                                                     .group = "Server setup",
+                                                     .accept_value = "integer",
+                                                     .default_value = ""}},
 };
 
 class ApiServerConfiguration {
@@ -107,7 +117,8 @@ class ApiServerConfiguration {
       const std::string& proxy_url = "", const std::string& proxy_username = "",
       const std::string& proxy_password = "", const std::string& no_proxy = "",
       bool verify_peer_ssl = true, bool verify_host_ssl = true,
-      const std::string& hf_token = "")
+      const std::string& hf_token = "", const std::string& server_host = "",
+      int server_port = 39281)
       : cors{cors},
         allowed_origins{allowed_origins},
         verify_proxy_ssl{verify_proxy_ssl},
@@ -118,7 +129,9 @@ class ApiServerConfiguration {
         no_proxy{no_proxy},
         verify_peer_ssl{verify_peer_ssl},
         verify_host_ssl{verify_host_ssl},
-        hf_token{hf_token} {}
+        hf_token{hf_token},
+        server_host{server_host},
+        server_port{server_port} {}
 
   // cors
   bool cors{true};
@@ -139,6 +152,9 @@ class ApiServerConfiguration {
   // token
   std::string hf_token{""};
 
+  std::string server_host{"127.0.0.1"};
+  int server_port{39281};
+
   Json::Value ToJson() const {
     Json::Value root;
     root["cors"] = cors;
@@ -155,7 +171,8 @@ class ApiServerConfiguration {
     root["verify_peer_ssl"] = verify_peer_ssl;
     root["verify_host_ssl"] = verify_host_ssl;
     root["huggingface_token"] = hf_token;
-
+    root["server_host"] = server_host;
+    root["server_port"] = server_port;
     return root;
   }
 
@@ -246,7 +263,22 @@ class ApiServerConfiguration {
                hf_token = value.asString();
                return true;
              }},
-
+            {"server_host",
+             [this](const Json::Value& value) -> bool {
+               if (!value.isString()) {
+                 return false;
+               }
+               server_host = value.asString();
+               return true;
+             }},
+            {"server_port",
+             [this](const Json::Value& value) -> bool {
+               if (!value.isNumeric()) {
+                 return false;
+               }
+               server_port = value.asInt();
+               return true;
+             }},
             {"cors",
              [this](const Json::Value& value) -> bool {
                if (!value.isBool()) {

engine/services/config_service.cc

@@ -5,11 +5,19 @@
 cpp::result<ApiServerConfiguration, std::string>
 ConfigService::UpdateApiServerConfiguration(const Json::Value& json) {
   auto config = file_manager_utils::GetCortexConfig();
-  ApiServerConfiguration api_server_config{
-      config.enableCors,         config.allowedOrigins,  config.verifyProxySsl,
-      config.verifyProxyHostSsl, config.proxyUrl,        config.proxyUsername,
-      config.proxyPassword,      config.noProxy,         config.verifyPeerSsl,
-      config.verifyHostSsl,      config.huggingFaceToken};
+  ApiServerConfiguration api_server_config{config.enableCors,
+                                           config.allowedOrigins,
+                                           config.verifyProxySsl,
+                                           config.verifyProxyHostSsl,
+                                           config.proxyUrl,
+                                           config.proxyUsername,
+                                           config.proxyPassword,
+                                           config.noProxy,
+                                           config.verifyPeerSsl,
+                                           config.verifyHostSsl,
+                                           config.huggingFaceToken,
+                                           config.apiServerHost,
+                                           std::stoi(config.apiServerPort)};
 
   std::vector<std::string> updated_fields;
   std::vector<std::string> invalid_fields;
@@ -36,6 +44,8 @@ ConfigService::UpdateApiServerConfiguration(const Json::Value& json) {
   config.verifyHostSsl = api_server_config.verify_host_ssl;
 
   config.huggingFaceToken = api_server_config.hf_token;
+  config.apiServerHost = api_server_config.server_host;
+  config.apiServerPort = std::to_string(api_server_config.server_port);
 
   auto result = file_manager_utils::UpdateCortexConfig(config);
   return api_server_config;
@@ -44,9 +54,17 @@ ConfigService::UpdateApiServerConfiguration(const Json::Value& json) {
 cpp::result<ApiServerConfiguration, std::string>
 ConfigService::GetApiServerConfiguration() {
   auto config = file_manager_utils::GetCortexConfig();
-  return ApiServerConfiguration{
-      config.enableCors,         config.allowedOrigins,  config.verifyProxySsl,
-      config.verifyProxyHostSsl, config.proxyUrl,        config.proxyUsername,
-      config.proxyPassword,      config.noProxy,         config.verifyPeerSsl,
-      config.verifyHostSsl,      config.huggingFaceToken};
+  return ApiServerConfiguration{config.enableCors,
+                                config.allowedOrigins,
+                                config.verifyProxySsl,
+                                config.verifyProxyHostSsl,
+                                config.proxyUrl,
+                                config.proxyUsername,
+                                config.proxyPassword,
+                                config.noProxy,
+                                config.verifyPeerSsl,
+                                config.verifyHostSsl,
+                                config.huggingFaceToken,
+                                config.apiServerHost,
+                                std::stoi(config.apiServerPort)};
 }