Fix/skip re download model yml (#1409)

* feat: relative path for data (part1)

* chore: unit tests

* fix: unit tests

* fix: more

* fix: windows

* fix: comments

* fix: use fs path

* Fix: redownload model.yml

* chore: move logic to file manager utils (#1405)

* Fix: unable to shorten model alias

---------

Co-authored-by: vansangpfiev <vansangpfiev@gmail.com>
Co-authored-by: vansangpfiev <sang@jan.ai>

Author: 3 people

engine/database/models.cc

@@ -86,7 +86,7 @@ std::string Models::GenerateShortenedAlias(
   std::vector<std::string> parts;
   std::istringstream iss(model_id);
   std::string part;
-  while (std::getline(iss, part, '/')) {
+  while (std::getline(iss, part, ':')) {
     parts.push_back(part);
   }
 
@@ -115,12 +115,12 @@ std::string Models::GenerateShortenedAlias(
 
   if (parts.size() >= 3) {
     candidates.push_back(parts[parts.size() - 3] + ":" +
-                         parts[parts.size() - 2] + "/" + filename);
+                         parts[parts.size() - 2] + ":" + filename);
   }
 
   if (parts.size() >= 4) {
-    candidates.push_back(parts[0] + ":" + parts[1] + "/" +
-                         parts[parts.size() - 2] + "/" + filename);
+    candidates.push_back(parts[0] + ":" + parts[1] + ":" +
+                         parts[parts.size() - 2] + ":" + filename);
   }
 
   // Find the first unique candidate

engine/services/download_service.cc

@@ -72,7 +72,7 @@ cpp::result<bool, std::string> DownloadService::AddDownloadTask(
     if (result.has_error()) {
       dl_err_msg = result.error();
       break;
-    } else if(result) {
+    } else if (result) {
       has_task_done |= result.value();
     }
   }
@@ -175,7 +175,9 @@ cpp::result<bool, std::string> DownloadService::Download(
                                      << " - " << existing_file_size);
       CTL_INF("Download item size: " << download_item.bytes.value());                               
       auto missing_bytes = download_item.bytes.value() - existing_file_size;
-      if (missing_bytes > 0) {
+      if (missing_bytes > 0 &&
+          download_item.localPath.extension().string() != ".yaml" &&
+          download_item.localPath.extension().string() != ".yml") {
         CLI_LOG("Found unfinished download! Additional "
                 << format_utils::BytesToHumanReadable(missing_bytes)
                 << " need to be downloaded.");
@@ -186,7 +188,7 @@ cpp::result<bool, std::string> DownloadService::Download(
           mode = "ab";
           CLI_LOG("Resuming download..");
         } else {
-          CLI_LOG("Start over..");          
+          CLI_LOG("Start over..");
         }
       } else {
         CLI_LOG(download_item.localPath.filename().string()

engine/test/components/test_models_db.cc

@@ -85,15 +85,15 @@ TEST_F(ModelsTestSuite, TestGenerateShortenedAlias) {
   EXPECT_TRUE(model_list_.AddModelEntry(kTestModel).value());
   auto models1 = model_list_.LoadModelList();
   auto alias = model_list_.GenerateShortenedAlias(
-      "huggingface.co/bartowski/llama3.1-7b-gguf/Model_ID_Xxx.gguf",
+      "huggingface.co:bartowski:llama3.1-7b-gguf:Model_ID_Xxx.gguf",
       models1.value());
   EXPECT_EQ(alias, "model_id_xxx");
   EXPECT_TRUE(model_list_.UpdateModelAlias(kTestModel.model, alias).value());
 
   // Test with existing entries to force longer alias
   auto models2 = model_list_.LoadModelList();
   alias = model_list_.GenerateShortenedAlias(
-      "huggingface.co/bartowski/llama3.1-7b-gguf/Model_ID_Xxx.gguf",
+      "huggingface.co:bartowski:llama3.1-7b-gguf:Model_ID_Xxx.gguf",
       models2.value());
   EXPECT_EQ(alias, "llama3.1-7b-gguf:model_id_xxx");
 

engine/utils/file_manager_utils.h

@@ -144,6 +144,9 @@ inline void CreateConfigFileIfNotExist() {
 
   auto config = config_yaml_utils::CortexConfig{
       .logFolderPath = defaultDataFolderPath.string(),
+      .logLlamaCppPath = kLogsLlamacppBaseName,
+      .logTensorrtLLMPath = kLogsTensorrtllmBaseName,
+      .logOnnxPath = kLogsOnnxBaseName,
       .dataFolderPath = defaultDataFolderPath.string(),
       .maxLogLines = config_yaml_utils::kDefaultMaxLines,
       .apiServerHost = config_yaml_utils::kDefaultHost,