remove validate task

Author: namchuai

engine/common/base.h

@@ -20,9 +20,6 @@ class BaseModel {
   virtual void GetModels(
       const HttpRequestPtr& req,
       std::function<void(const HttpResponsePtr&)>&& callback) = 0;
-  virtual void GetEngines(
-      const HttpRequestPtr& req,
-      std::function<void(const HttpResponsePtr&)>&& callback) = 0;
   virtual void FineTuning(
       const HttpRequestPtr& req,
       std::function<void(const HttpResponsePtr&)>&& callback) = 0;
@@ -48,4 +45,4 @@ class BaseEmbedding {
       std::function<void(const HttpResponsePtr&)>&& callback) = 0;
 
   // The derived class can also override other methods if needed
-};
+};

engine/services/download_service.cc

@@ -27,43 +27,9 @@ size_t WriteCallback(char* ptr, size_t size, size_t nmemb, void* userdata) {
 }
 }  // namespace
 
-cpp::result<void, std::string> DownloadService::VerifyDownloadTask(
-    DownloadTask& task) const noexcept {
-  CLI_LOG("Validating download items, please wait..");
-
-  auto total_download_size{0};
-  std::optional<std::string> err_msg = std::nullopt;
-
-  for (auto& item : task.items) {
-    auto file_size = GetFileSize(item.downloadUrl);
-    if (file_size.has_error()) {
-      err_msg = file_size.error();
-      break;
-    }
-
-    item.bytes = file_size.value();
-    total_download_size += file_size.value();
-  }
-
-  if (err_msg.has_value()) {
-    CTL_ERR(err_msg.value());
-    return cpp::fail(err_msg.value());
-  }
-
-  return {};
-}
-
 cpp::result<bool, std::string> DownloadService::AddDownloadTask(
     DownloadTask& task,
     std::optional<OnDownloadTaskSuccessfully> callback) noexcept {
-  auto validating_result = VerifyDownloadTask(task);
-  if (validating_result.has_error()) {
-    return cpp::fail(validating_result.error());
-  }
-
-  // all items are valid, start downloading
-  // if any item from the task failed to download, the whole task will be
-  // considered failed
   std::optional<std::string> dl_err_msg = std::nullopt;
   bool has_task_done = false;
   for (const auto& item : task.items) {
@@ -262,7 +228,7 @@ void DownloadService::ProcessTask(DownloadTask& task) {
 
   active_task_ = std::make_shared<DownloadTask>(task);
 
-  for (auto& item : task.items) {
+  for (const auto& item : task.items) {
     auto handle = curl_easy_init();
     if (handle == nullptr) {
       // skip the task
@@ -408,11 +374,6 @@ void DownloadService::ProcessCompletedTransfers() {
 
 cpp::result<DownloadTask, std::string> DownloadService::AddTask(
     DownloadTask& task, std::function<void(const DownloadTask&)> callback) {
-  auto validate_result = VerifyDownloadTask(task);
-  if (validate_result.has_error()) {
-    return cpp::fail(validate_result.error());
-  }
-
   {
     std::lock_guard<std::mutex> lock(callbacks_mutex_);
     callbacks_[task.id] = std::move(callback);

engine/services/download_service.h

@@ -86,9 +86,6 @@ class DownloadService {
     DownloadService* download_service;
   };
 
-  cpp::result<void, std::string> VerifyDownloadTask(
-      DownloadTask& task) const noexcept;
-
   cpp::result<bool, std::string> Download(
       const std::string& download_id,
       const DownloadItem& download_item) noexcept;

engine/services/inference_service.h

@@ -46,8 +46,6 @@ class InferenceService {
 
   InferResult GetModels(std::shared_ptr<Json::Value> json_body);
 
-  Json::Value GetEngines(std::shared_ptr<Json::Value> json_body);
-
   InferResult FineTuning(std::shared_ptr<Json::Value> json_body);
 
  private: