chore: add default contructor and values to remove garbage values at runtime

Author: github-roushan

engine/utils/hardware/gguf/ggml.h

@@ -83,11 +83,9 @@ inline float GetQuantBit(GGMLType gt) {
     case GGML_TYPE_Q8_1:
     case GGML_TYPE_Q8_K:
       return 8.0f;
-
     case GGML_TYPE_I64:
     case GGML_TYPE_F64:
       return 64.0f;
-
     default:
       return 8.0f;
   }
@@ -171,7 +169,7 @@ inline std::string to_string(GGMLType t) {
 struct GGMLTypeTrait {
   uint64_t block_size;
   uint64_t type_size;
-  bool is_quantized;
+  bool is_quantized = false;
 };
 
 const std::unordered_map<GGMLType, GGMLTypeTrait> kGGMLTypeTraits = {

engine/utils/hardware/gguf/gguf_file.h

@@ -49,6 +49,8 @@ constexpr const GGUFVersion kGGUFVersionV1 = 1;
 constexpr const GGUFVersion kGGUFVersionV2 = 2;
 constexpr const GGUFVersion kGGUFVersionV3 = 3;
 
+constexpr std::size_t kMaxElementsToShow = 50;
+
 enum GGUFMetadataValueType : uint32_t {
   GGUFMetadataValueTypeUint8 = 0,
   GGUFMetadataValueTypeInt8,
@@ -129,10 +131,21 @@ inline std::string to_string(GGUFMetadataValueType vt, const std::any& v) {
   return "array";
 }
 inline std::string to_string(const GGUFMetadataKVArrayValue& arr_v) {
-  std::string res;
-  auto num = std::min(size_t(5), arr_v.arr.size());
-  for (size_t i = 0; i < num; i++) {
-    res += to_string(arr_v.type, arr_v.arr[i]) + " ";
+  std::string res = "[";
+  size_t array_size = arr_v.arr.size();
+  size_t elementsToShow = std::min(kMaxElementsToShow, array_size);
+  for (size_t i = 0; i < elementsToShow; i++) {
+    res += to_string(arr_v.type, arr_v.arr[i]) + ", ";
+  }
+  if(array_size > 0) {
+    res.pop_back();
+    res.pop_back();
+  }
+  res += "]";
+  if(array_size > elementsToShow) {
+    res += "... (";
+    res += std::to_string(array_size - elementsToShow);
+    res += " more elements)";
   }
   return res;
 }
@@ -193,6 +206,9 @@ struct GGUFTensorInfo {
   //
   // The offset is the start of the file.
   int64_t start_offset;
+
+  GGUFTensorInfo()
+  : name(""), n_dimensions(0), dimensions(), type(GGMLType{}), offset(0), start_offset(0) {}
 };
 
 struct GGUFHelper {
@@ -421,6 +437,10 @@ struct GGUFHeader {
   // MetadataKV are the key-value pairs in the metadata,
   std::vector<GGUFMetadataKV> metadata_kv;
 
+  // Constructor to initialize member variables.
+  GGUFHeader()
+    : magic{0}, version{0}, tensor_count(0), metadata_kv_count(0), metadata_kv() {}
+
   std::pair<GGUFMetadataKV, bool> Get(const std::string& name) {
     for (auto const& kv : metadata_kv) {
       if (kv.key == name) {
@@ -480,6 +500,20 @@ struct GGUFFile {
   // which describes how many bits are used to store a weight,
   // higher is better.
   double model_bits_per_weight;
+
+  GGUFFile()
+    : header(),
+      tensor_infos(),
+      padding(0),
+      split_paddings(),
+      tensor_data_start_offset(-1),
+      split_tensor_data_start_offsets(),
+      size(0),
+      split_sizes(),
+      model_size(0),
+      split_model_sizes(),
+      model_parameters(0),
+      model_bits_per_weight(0.0) {}
 };
 
 inline std::optional<GGUFFile> ParseGgufFile(const std::string& path) {