Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

Commit ecf9b9a

Browse files
committed
chore: remove trt-llm log path config
1 parent 66da6fc commit ecf9b9a

File tree

6 files changed

+7
-20
lines changed

6 files changed

+7
-20
lines changed

docs/docs/architecture/cortexrc.mdx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ Example of the `.cortexrc` file:
4444
```
4545
logFolderPath: /home/<user>/cortexcpp
4646
logLlamaCppPath: ./logs/cortex.log
47-
logTensorrtLLMPath: ./logs/cortex.log
4847
logOnnxPath: ./logs/cortex.log
4948
dataFolderPath: /home/<user>/cortexcpp
5049
maxLogLines: 100000

engine/test/components/test_cortex_config.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ class CortexConfigTest : public ::testing::Test {
1616
// Set up default configuration
1717
default_config = {"default_log_path",
1818
"default_llamacpp_log_path",
19-
"default_tensorrtllm_log_path",
2019
"default_onnx_log_path",
2120
"default_data_path",
2221
1000,
@@ -38,7 +37,6 @@ class CortexConfigTest : public ::testing::Test {
3837
TEST_F(CortexConfigTest, DumpYamlConfig_WritesCorrectly) {
3938
CortexConfig config = {"log_path",
4039
"default_llamacpp_log_path",
41-
"default_tensorrtllm_log_path",
4240
"default_onnx_log_path",
4341
"data_path",
4442
5000,
@@ -68,7 +66,6 @@ TEST_F(CortexConfigTest, FromYaml_ReadsCorrectly) {
6866
// First, create a valid YAML configuration file
6967
CortexConfig config = {"log_path",
7068
"default_llamacpp_log_path",
71-
"default_tensorrtllm_log_path",
7269
"default_onnx_log_path",
7370
"data_path",
7471
5000,

engine/utils/config_yaml_utils.cc

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ cpp::result<void, std::string> CortexConfigMgr::DumpYamlConfig(
2222
YAML::Node node;
2323
node["logFolderPath"] = config.logFolderPath;
2424
node["logLlamaCppPath"] = config.logLlamaCppPath;
25-
node["logTensorrtLLMPath"] = config.logTensorrtLLMPath;
2625
node["logOnnxPath"] = config.logOnnxPath;
2726
node["dataFolderPath"] = config.dataFolderPath;
2827
node["maxLogLines"] = config.maxLogLines;
@@ -78,11 +77,10 @@ CortexConfig CortexConfigMgr::FromYaml(const std::string& path,
7877
!node["apiServerPort"] || !node["checkedForUpdateAt"] ||
7978
!node["checkedForLlamacppUpdateAt"] || !node["latestRelease"] ||
8079
!node["latestLlamacppRelease"] || !node["logLlamaCppPath"] ||
81-
!node["logOnnxPath"] || !node["logTensorrtLLMPath"] ||
82-
!node["huggingFaceToken"] || !node["gitHubUserAgent"] ||
83-
!node["gitHubToken"] || !node["llamacppVariant"] ||
84-
!node["llamacppVersion"] || !node["enableCors"] ||
85-
!node["allowedOrigins"] || !node["proxyUrl"] ||
80+
!node["logOnnxPath"] || !node["huggingFaceToken"] ||
81+
!node["gitHubUserAgent"] || !node["gitHubToken"] ||
82+
!node["llamacppVariant"] || !node["llamacppVersion"] ||
83+
!node["enableCors"] || !node["allowedOrigins"] || !node["proxyUrl"] ||
8684
!node["proxyUsername"] || !node["proxyPassword"] ||
8785
!node["verifyPeerSsl"] || !node["verifyHostSsl"] ||
8886
!node["verifyProxySsl"] || !node["verifyProxyHostSsl"] ||
@@ -97,9 +95,6 @@ CortexConfig CortexConfigMgr::FromYaml(const std::string& path,
9795
.logLlamaCppPath = node["logLlamaCppPath"]
9896
? node["logLlamaCppPath"].as<std::string>()
9997
: default_cfg.logLlamaCppPath,
100-
.logTensorrtLLMPath = node["logTensorrtLLMPath"]
101-
? node["logTensorrtLLMPath"].as<std::string>()
102-
: default_cfg.logTensorrtLLMPath,
10398
.logOnnxPath = node["logOnnxPath"]
10499
? node["logOnnxPath"].as<std::string>()
105100
: default_cfg.logOnnxPath,
@@ -183,10 +178,9 @@ CortexConfig CortexConfigMgr::FromYaml(const std::string& path,
183178
.checkedForSyncHubAt = node["checkedForSyncHubAt"]
184179
? node["checkedForSyncHubAt"].as<uint64_t>()
185180
: default_cfg.checkedForSyncHubAt,
186-
.apiKeys =
187-
node["apiKeys"]
188-
? node["apiKeys"].as<std::vector<std::string>>()
189-
: default_cfg.apiKeys,
181+
.apiKeys = node["apiKeys"]
182+
? node["apiKeys"].as<std::vector<std::string>>()
183+
: default_cfg.apiKeys,
190184

191185
};
192186
if (should_update_config) {

engine/utils/config_yaml_utils.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ const std::vector<std::string> kDefaultSupportedEngines{kLlamaEngine,
3030
struct CortexConfig {
3131
std::string logFolderPath;
3232
std::string logLlamaCppPath;
33-
std::string logTensorrtLLMPath;
3433
std::string logOnnxPath;
3534
std::string dataFolderPath;
3635

engine/utils/file_manager_utils.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,6 @@ config_yaml_utils::CortexConfig GetDefaultConfig() {
188188
.logFolderPath = default_data_folder_path.string(),
189189
#endif
190190
.logLlamaCppPath = kLogsLlamacppBaseName,
191-
.logTensorrtLLMPath = kLogsTensorrtllmBaseName,
192191
.logOnnxPath = kLogsOnnxBaseName,
193192
#if defined(_WIN32)
194193
.dataFolderPath =

engine/utils/file_manager_utils.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ constexpr std::string_view kProdVariant = "prod";
1313
constexpr std::string_view kBetaVariant = "beta";
1414
constexpr std::string_view kNightlyVariant = "nightly";
1515
constexpr char kLogsLlamacppBaseName[] = "./logs/cortex.log";
16-
constexpr char kLogsTensorrtllmBaseName[] = "./logs/cortex.log";
1716
constexpr char kLogsOnnxBaseName[] = "./logs/cortex.log";
1817

1918
inline std::string cortex_config_file_path;

0 commit comments

Comments
 (0)