I think the CMakeLists are correct, less sure about rest.

Author: jd-boyd

CMakeLists.txt

@@ -1,10 +1,9 @@
 cmake_minimum_required(VERSION 3.15)
+
 project(python_lzo)
 
 # Set C/C++ standards
 set(CMAKE_C_STANDARD 11)
-set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 # Option to use system liblzo instead of building from source
 option(USE_SYSTEM_LZO "Use system-installed liblzo instead of building from source" OFF)
@@ -16,7 +15,6 @@ endif()
 
 # Find Python for the extension
 find_package(Python COMPONENTS Interpreter Development REQUIRED)
-find_package(pybind11 CONFIG REQUIRED)
 
 if(USE_SYSTEM_LZO)
     # Use system-installed liblzo
@@ -25,41 +23,41 @@ if(USE_SYSTEM_LZO)
         PATHS /usr/lib /usr/local/lib /opt/local/lib
         DOC "liblzo library"
     )
-    
+
     find_path(LZO_INCLUDE_DIR
         NAMES lzo/lzo1x.h
         PATHS /usr/include /usr/local/include /opt/local/include
         DOC "liblzo include directory"
     )
-    
+
     if(NOT LZO_LIBRARY OR NOT LZO_INCLUDE_DIR)
         message(FATAL_ERROR "System liblzo not found. Install liblzo-dev or disable USE_SYSTEM_LZO")
     endif()
-    
+
     message(STATUS "Using system liblzo: ${LZO_LIBRARY}")
     message(STATUS "liblzo headers: ${LZO_INCLUDE_DIR}")
-    
+
     # Create imported target for system liblzo
     add_library(lzo_lib SHARED IMPORTED)
     set_target_properties(lzo_lib PROPERTIES
         IMPORTED_LOCATION ${LZO_LIBRARY}
         INTERFACE_INCLUDE_DIRECTORIES ${LZO_INCLUDE_DIR}
     )
-    
+
 else()
     # Build liblzo from source in lzo-2.10 subdirectory
     set(LZO_PROJECT_DIR "${CMAKE_CURRENT_SOURCE_DIR}/lzo-2.10")
     set(LZO_BUILD_DIR "${CMAKE_CURRENT_BINARY_DIR}/lzo_build")
-    
+
     # Determine build command based on platform
     if(WIN32)
         # Windows: Use MSBuild
-        set(LZO_BUILD_COMMAND 
-            msbuild lzo_static_lib.vcxproj 
+        set(LZO_BUILD_COMMAND
+            msbuild lzo_static_lib.vcxproj
             -p:Configuration=Release$<SEMICOLON>Platform=x64$<SEMICOLON>OutDir=..\\
         )
         set(LZO_STATIC_LIB "${LZO_BUILD_DIR}/lzo2.lib")
-        set(LZO_CONFIGURE_COMMAND 
+        set(LZO_CONFIGURE_COMMAND
             ${CMAKE_COMMAND} -S ${LZO_PROJECT_DIR} -B ${LZO_BUILD_DIR}
             -DCMAKE_BUILD_TYPE=Release
             -A x64
@@ -70,16 +68,16 @@ else()
         if(APPLE)
             set(LZO_STATIC_LIB "${LZO_BUILD_DIR}/src/.libs/liblzo2.a")
         else()
-            set(LZO_STATIC_LIB "${LZO_BUILD_DIR}/src/.libs/liblzo2.a")
+            set(LZO_STATIC_LIB "${LZO_BUILD_DIR}/liblzo2.a")
         endif()
-        set(LZO_CONFIGURE_COMMAND 
+        set(LZO_CONFIGURE_COMMAND
             ${CMAKE_COMMAND} -S ${LZO_PROJECT_DIR} -B ${LZO_BUILD_DIR}
             -DCMAKE_BUILD_TYPE=Release
             -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
             -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
         )
     endif()
-    
+
     # Configure and build liblzo using ExternalProject
     include(ExternalProject)
     ExternalProject_Add(lzo_project
@@ -91,49 +89,45 @@ else()
         BUILD_BYPRODUCTS ${LZO_STATIC_LIB}
         BUILD_IN_SOURCE 0
     )
-    
+
     # Create an imported target for the built liblzo static library
     add_library(lzo_lib STATIC IMPORTED)
     set_target_properties(lzo_lib PROPERTIES
         IMPORTED_LOCATION ${LZO_STATIC_LIB}
         INTERFACE_INCLUDE_DIRECTORIES ${LZO_PROJECT_DIR}/include
     )
-    
+
     # Make sure liblzo is built before we try to use it
     add_dependencies(lzo_lib lzo_project)
 endif()
 
 # Compile the lzomodule.c file into an object library
-add_library(lzomodule_objects OBJECT
+add_library(lzo_module SHARED
     lzomodule.c
 )
 
 # Set properties for the object library
-target_include_directories(lzomodule_objects PRIVATE
+target_include_directories(lzo_module PRIVATE
     ${Python_INCLUDE_DIRS}
 )
 
 if(USE_SYSTEM_LZO)
-    target_include_directories(lzomodule_objects PRIVATE ${LZO_INCLUDE_DIR})
+    target_include_directories(lzo_module PRIVATE ${LZO_INCLUDE_DIR})
 else()
-    target_include_directories(lzomodule_objects PRIVATE ${LZO_PROJECT_DIR}/include)
+    target_include_directories(lzo_module PRIVATE ${LZO_PROJECT_DIR}/include)
 endif()
 
-# Create the final Python extension module
-pybind11_add_module(lzo_module 
-    $<TARGET_OBJECTS:lzomodule_objects>
-)
 
 # Link the lzo library (either system or built from source)
-target_link_libraries(lzo_module PRIVATE 
+target_link_libraries(lzo_module PRIVATE
     lzo_lib
     ${Python_LIBRARIES}
 )
 
 # Set target properties
 set_target_properties(lzo_module PROPERTIES
-    OUTPUT_NAME "lzo"  # This will create lzo.so/.dll/.pyd
-    CXX_VISIBILITY_PRESET "hidden"
+  OUTPUT_NAME "lzo"  # This will create lzo.so/.dll/.pyd
+  PREFIX ""
     INTERPROCEDURAL_OPTIMIZATION TRUE
 )
 
@@ -168,10 +162,10 @@ endif()
 if(CMAKE_BUILD_TYPE STREQUAL "Release")
     if(MSVC)
         target_compile_options(lzo_module PRIVATE /O2)
-        target_compile_options(lzomodule_objects PRIVATE /O2)
+        target_compile_options(lzo_modules PRIVATE /O2)
     else()
         target_compile_options(lzo_module PRIVATE -O3 -march=native)
-        target_compile_options(lzomodule_objects PRIVATE -O3 -march=native)
+        target_compile_options(lzo_modules PRIVATE -O3 -march=native)
     endif()
 endif()
 
@@ -192,4 +186,4 @@ else()
         message(STATUS "  Build tool: make")
     endif()
 endif()
-message(STATUS "")
+message(STATUS "")

lzo-2.10/CMakeLists.txt

@@ -8,7 +8,7 @@
 # All Rights Reserved.
 #
 
-cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
+cmake_minimum_required(VERSION 3.6 FATAL_ERROR)
 
 #
 # simple usage example (Unix):

setup.py

@@ -5,7 +5,6 @@
 from pathlib import Path
 from setuptools import setup, Extension
 from setuptools.command.build_ext import build_ext
-import pybind11
 
 
 class CMakeExtension(Extension):
@@ -41,7 +40,6 @@ def build_extension(self, ext):
             f"-DCMAKE_LIBRARY_OUTPUT_DIRECTORY={extdir}",
             f"-DPYTHON_EXECUTABLE={sys.executable}",
             f"-DCMAKE_BUILD_TYPE={cfg}",  # not used on MSVC, but no harm
-            f"-DPYBIND11_PYTHON_VERSION={sys.version_info.major}.{sys.version_info.minor}",
             f"-DUSE_SYSTEM_LZO={use_system_lzo}",
         ]
 
@@ -76,8 +74,6 @@ def build_extension(self, ext):
             if hasattr(self, "parallel") and self.parallel:
                 build_args += [f"-j{self.parallel}"]
 
-        cmake_args += [f"-DPYBIND11_INCLUDE_DIR={pybind11.get_include()}"]
-
         build_temp = os.path.join(self.build_temp, ext.name)
         if not os.path.exists(build_temp):
             os.makedirs(build_temp)