Skip to content

Commit 2f12665

Browse files
authored
Merge pull request #43 from jeantimex/simplify-heightForRowAt
Simplify heightForRowAt.
2 parents 360c9af + f46fc5e commit 2f12665

File tree

3 files changed

+2
-25
lines changed

3 files changed

+2
-25
lines changed

CollapsibleTableSectionViewController.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
1616
#
1717

1818
s.name = "CollapsibleTableSectionViewController"
19-
s.version = "1.0.0"
19+
s.version = "1.0.1"
2020
s.summary = "Swift 3.0 library to support collapsible sections in a table view."
2121

2222
# This description is used to generate tags and improve search results.

CollapsibleTableSectionViewController/CollapsibleTableSectionViewController.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@ extension CollapsibleTableSectionViewController: UITableViewDataSource, UITableV
109109
}
110110

111111
public func tableView(_ tableView: UITableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
112-
let section = (indexPath as NSIndexPath).section
113-
return isSectionCollapsed(section) ? 0 : UITableViewAutomaticDimension
112+
return UITableViewAutomaticDimension
114113
}
115114

116115
public func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {

CollapsibleTableSectionViewControllerTests/CollapsibleTableSectionViewControllerTests.swift

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -150,29 +150,7 @@ class CollapsibleTableSectionViewControllerTests: XCTestCase {
150150
// Test heightForRowAt
151151
//
152152

153-
func testReturnsZeroWhenSectionIsCollapsed() {
154-
class MockCollapsibleTableSectionViewController: CollapsibleTableSectionViewController {
155-
override public func isSectionCollapsed(_ section: Int) -> Bool {
156-
return true
157-
}
158-
}
159-
160-
viewController = MockCollapsibleTableSectionViewController()
161-
162-
let heightForRowAt = viewController.tableView(tableView, heightForRowAt: IndexPath(row: 0, section: 0))
163-
164-
XCTAssertEqual(heightForRowAt, 0)
165-
}
166-
167153
func testReturnsUITableViewAutomaticDimension() {
168-
class MockCollapsibleTableSectionViewController: CollapsibleTableSectionViewController {
169-
override public func isSectionCollapsed(_ section: Int) -> Bool {
170-
return false
171-
}
172-
}
173-
174-
viewController = MockCollapsibleTableSectionViewController()
175-
176154
let heightForRowAt = viewController.tableView(tableView, heightForRowAt: IndexPath(row: 0, section: 0))
177155

178156
XCTAssertEqual(heightForRowAt, UITableViewAutomaticDimension)

0 commit comments

Comments
 (0)