Skip to content

Commit 4b4bdee

Browse files
committed
[JENKINS-76302] Make GH org avatars work with CSP
1 parent 9ee8a39 commit 4b4bdee

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pom.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,11 @@
3535
<hpi.compatibleSinceVersion>2.2.0</hpi.compatibleSinceVersion>
3636
<!-- https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/ -->
3737
<jenkins.baseline>2.504</jenkins.baseline>
38-
<jenkins.version>${jenkins.baseline}.3</jenkins.version>
38+
<!-- TODO https://github.com/jenkinsci/jenkins/pull/11269 -->
39+
<jenkins.version>2.537-rc37714.d5718019b_8ff</jenkins.version>
3940
<spotless.check.skip>false</spotless.check.skip>
41+
<!-- AvatarContributor in GitHubOrgMetadataAction; SuppressRestrictedWarnings doesn't work -->
42+
<useBeta>true</useBeta>
4043
</properties>
4144

4245
<dependencyManagement>

src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubOrgMetadataAction.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import java.io.ObjectStreamException;
3333
import java.util.Objects;
3434
import jenkins.scm.api.metadata.AvatarMetadataAction;
35+
import jenkins.security.csp.AvatarContributor;
3536
import org.apache.commons.lang3.StringUtils;
3637
import org.kohsuke.github.GHUser;
3738
import org.kohsuke.stapler.Stapler;
@@ -52,6 +53,7 @@ public GitHubOrgMetadataAction(@NonNull GHUser org) throws IOException {
5253

5354
public GitHubOrgMetadataAction(@CheckForNull String avatar) {
5455
this.avatar = Util.fixEmpty(avatar);
56+
AvatarContributor.allow(avatar);
5557
}
5658

5759
public GitHubOrgMetadataAction(@NonNull GitHubOrgMetadataAction that) {
@@ -60,6 +62,7 @@ public GitHubOrgMetadataAction(@NonNull GitHubOrgMetadataAction that) {
6062

6163
private Object readResolve() throws ObjectStreamException {
6264
if (avatar != null && StringUtils.isBlank(avatar)) return new GitHubOrgMetadataAction(this);
65+
AvatarContributor.allow(avatar);
6366
return this;
6467
}
6568

0 commit comments

Comments
 (0)