Skip to content

Commit 9d1f48e

Browse files
authored
Merge pull request #295 from jglick/AbstractGitHubNotificationStrategy
AbstractGitHubNotificationStrategy is not an ExtensionPoint
2 parents e55cd5f + 37313dd commit 9d1f48e

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

docs/implementation.adoc

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
= Implementation Guide
22

3-
== Extension Points
4-
5-
=== AbstractGitHubNotificationStrategy
6-
This extension points allows traits to modify the contents of a Github status notification for a build.
3+
== AbstractGitHubNotificationStrategy
4+
This API allows traits to modify the contents of a GitHub status notification for a build.
75
There are currently 3 points in a build lifecycle where notifications are sent:
86

97
* On entering the queue
@@ -44,7 +42,6 @@ explicitly apply a `DefaultGitHubNotificationStrategy` to the source context in
4442

4543
Duplicate (by equality) strategies are ignored when applied to the source context.
4644

47-
==== Implementations:
48-
https://github.com/jenkinsci/github-scm-trait-notification-context-plugin[github-scm-trait-notification-context]
49-
45+
=== Implementations:
5046

47+
https://github.com/jenkinsci/github-scm-trait-notification-context-plugin[github-scm-trait-notification-context]

src/main/java/org/jenkinsci/plugins/github_branch_source/AbstractGitHubNotificationStrategy.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
package org.jenkinsci.plugins.github_branch_source;
2626

27-
import hudson.ExtensionPoint;
2827
import hudson.model.TaskListener;
2928

3029
import java.util.List;
@@ -33,7 +32,7 @@
3332
* Represents a strategy for constructing GitHub status notifications
3433
* @since 2.3.2
3534
*/
36-
public abstract class AbstractGitHubNotificationStrategy implements ExtensionPoint {
35+
public abstract class AbstractGitHubNotificationStrategy {
3736

3837
/**
3938
* Creates the list of {@link GitHubNotificationRequest} for the given context.

0 commit comments

Comments
 (0)