refactor: Use property convention for gitDirectory default value

Author: Joel Mongård

src/main/kotlin/git/semver/plugin/gradle/GitSemverPlugin.kt

@@ -23,7 +23,7 @@ class GitSemverPlugin: Plugin<Project> {
         if (project == project.rootProject) {
             project.tasks.register("printChangeLog", PrintTask::class.java, {
                 val settings = extension.createSettings()
-                val changeLog = GitProvider(settings).getChangeLog(extension.gitDir.get().asFile)
+                val changeLog = GitProvider(settings).getChangeLog(extension.gitDirectory.get().asFile)
 
                 extension.changeLogFormat.formatLog(
                     changeLog,

src/main/kotlin/git/semver/plugin/gradle/GitSemverPluginExtension.kt

@@ -14,12 +14,15 @@ import org.gradle.api.tasks.Internal
 
 
 abstract class GitSemverPluginExtension(project: Project, providerFactory: ProviderFactory) : BaseSettings() {
+    init {
+        gitDirectory.convention(project.layout.projectDirectory)
+    }
+
     private val defaultPreReleaseProperty = project.findProperty("defaultPreRelease")
     private val noDirtyCheckProperty = project.findProperty("noDirtyCheck")
-    private val projectDir = project.layout.projectDirectory;
 
     /**
-     * Directory where to find the git project. If the git directory is a parent of this directory it will be found.
+     * Directory where to find the git project. If the git directory is a parent of this directory, it will be found.
      * Default: project dir.
      */
     abstract val gitDirectory: DirectoryProperty
@@ -113,22 +116,18 @@ abstract class GitSemverPluginExtension(project: Project, providerFactory: Provi
     val version: String by lazy { versionValue.toString() }
 
     private var semInfoVersionValueSource = project.providers.of(SemInfoVersionValueSource::class.java) {
-        it.parameters.getGitDir().set(gitDir);
+        it.parameters.getGitDir().set(gitDirectory);
         it.parameters.getSettings().set(providerFactory.provider {
             createSettings()
         })
     }
     private var semVersionValueSource = project.providers.of(SemVersionValueSource::class.java) {
-        it.parameters.getGitDir().set(gitDir);
+        it.parameters.getGitDir().set(gitDirectory);
         it.parameters.getSettings().set(providerFactory.provider {
             createSettings()
         })
     }
 
-    @get:Internal
-    internal val gitDir: Provider<Directory>
-        get() = gitDirectory.orElse(projectDir)
-
     internal fun createSettings(): SemverSettings {
         return SemverSettings(this).apply {
             if (defaultPreReleaseProperty is String) {

src/main/kotlin/git/semver/plugin/gradle/ReleaseTask.kt

@@ -57,7 +57,7 @@ open class ReleaseTask @Inject constructor(private val settings: GitSemverPlugin
 
     @TaskAction
     fun createRelease() {
-        GitProvider(settings.createSettings()).createRelease(settings.gitDir.get().asFile, getReleaseParams())
+        GitProvider(settings.createSettings()).createRelease(settings.gitDirectory.get().asFile, getReleaseParams())
     }
 
     @Internal