feat: change the default keepRunning to true

Author: johnste

apps/finicky/src/main.go

@@ -68,7 +68,7 @@ var dryRun bool = false
 var updateInfo UpdateInfo
 var configInfo *ConfigInfo
 var currentConfigState *config.ConfigState
-var shouldKeepRunning bool = false
+var shouldKeepRunning bool = true
 
 func main() {
 	startTime := time.Now()
@@ -234,7 +234,7 @@ func getKeepRunning() bool {
 		return false
 	}
 
-	keepRunning, err := vm.Runtime().RunString("finickyConfigAPI.getOption('keepRunning', finalConfig, false)")
+	keepRunning, err := vm.Runtime().RunString("finickyConfigAPI.getOption('keepRunning', finalConfig, true)")
 	if err != nil {
 		return false
 	}

apps/finicky/src/main.m

@@ -17,10 +17,10 @@ @implementation BrowseAppDelegate
 - (instancetype)initWithForceOpenWindow:(bool)forceOpenWindow initShow:(bool)showMenuItem keepRunning:(bool)keepRunning {
     self = [super init];
     if (self) {
-    _forceOpenWindow = forceOpenWindow;
-    _showMenuItem = showMenuItem;
-    _keepRunning = keepRunning;
-    _receivedURL = false;
+        _forceOpenWindow = forceOpenWindow;
+        _showMenuItem = showMenuItem;
+        _keepRunning = keepRunning;
+        _receivedURL = false;
     }
     return self;
 }
@@ -112,7 +112,10 @@ - (void)handleGetURLEvent:(NSAppleEventDescriptor *)event
     self.receivedURL = true;
 
     NSRunningApplication *frontApp = [[NSWorkspace sharedWorkspace] frontmostApplication];
-    bool finickyIsInFront = [frontApp isEqual:[NSRunningApplication currentApplication]];
+
+    // Assume Finicky is in front if we are not keeping running, since there's no good way
+    // to detect if Finicky was launched in the background
+    bool finickyIsInFront =  !self.keepRunning || [frontApp isEqual:[NSRunningApplication currentApplication]];
 
     if (application) {
         NSString *appName = [application localizedName];