Add UsernameService

Author: dansup

app/Http/Controllers/Auth/RegisterController.php

@@ -4,10 +4,10 @@
 
 use App\Http\Controllers\Controller;
 use App\Models\User;
+use App\Services\UsernameService;
 use Illuminate\Foundation\Auth\RegistersUsers;
 use Illuminate\Support\Facades\Hash;
 use Illuminate\Support\Facades\Validator;
-use Illuminate\Validation\Rule;
 
 class RegisterController extends Controller
 {
@@ -56,7 +56,11 @@ protected function validator(array $data)
                 'min:2',
                 'max:30',
                 'unique:users,username',
-                Rule::notIn(['admin', 'dansup', 'support', 'loops', 'official', 'team', 'teamLoops', 'new', 'discover', 'explore']),
+                function ($attribute, $value, $fail) {
+                    if (app(UsernameService::class)->isReserved($value)) {
+                        $fail('This username is reserved.');
+                    }
+                },
             ],
             'email' => ['required', 'string', 'email:rfc,dns,spoof,strict', 'max:255', 'unique:users'],
             'password' => ['required', 'string', 'min:8', 'confirmed'],

app/Http/Requests/StoreRegisterUsernameRequest.php

@@ -3,9 +3,9 @@
 namespace App\Http\Requests;
 
 use App\Models\AdminSetting;
+use App\Services\UsernameService;
 use Illuminate\Auth\Access\AuthorizationException;
 use Illuminate\Foundation\Http\FormRequest;
-use Illuminate\Validation\Rule;
 
 class StoreRegisterUsernameRequest extends FormRequest
 {
@@ -43,7 +43,11 @@ public function rules(): array
                 'min:2',
                 'max:30',
                 'unique:users,username',
-                Rule::notIn(['admin', 'dansup', 'support', 'loops', 'official', 'team', 'teamLoops', 'new', 'discover', 'explore']),
+                function ($attribute, $value, $fail) {
+                    if (app(UsernameService::class)->isReserved($value)) {
+                        $fail('This username is reserved.');
+                    }
+                },
             ],
             'password' => 'required|min:8',
             'password_confirmation' => 'required|confirmed:password',

app/Services/UsernameService.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace App\Services;
+
+class UsernameService
+{
+    public function reserved()
+    {
+        return [
+            'admin', 'administrator', 'root', 'system', 'sysadmin',
+            'support', 'help', 'helpdesk', 'service',
+
+            'loops', 'loop', 'official', 'staff', 'team', 'teamLoops',
+            'pixelfed',
+
+            'moderator', 'mod', 'mods', 'moderation',
+
+            'new', 'discover', 'explore', 'trending', 'popular',
+            'featured', 'verified', 'recommended',
+
+            'user', 'username', 'account', 'profile',
+            'everyone', 'all', 'users',
+
+            'inbox', 'outbox', 'followers', 'following',
+            'actor', 'shared', 'public', 'instance',
+
+            'api', 'oauth', 'token', 'auth', 'login',
+            'register', 'signup', 'signout', 'logout',
+            'webhook', 'callback', 'feed', 'rss',
+
+            'info', 'contact', 'news', 'press', 'legal',
+            'privacy', 'terms', 'tos', 'about', 'abuse',
+            'security', 'dmca', 'copyright',
+
+            'verified', 'official', 'real', 'authentic',
+        ];
+    }
+
+    public function wildcardPatterns()
+    {
+        return [
+            'admin*',
+        ];
+    }
+
+    public function isReserved(string $username): bool
+    {
+        $username = strtolower($username);
+
+        if (in_array($username, $this->reserved())) {
+            return true;
+        }
+
+        foreach ($this->wildcardPatterns() as $pattern) {
+            if ($this->matchesPattern($username, $pattern)) {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    protected function matchesPattern(string $username, string $pattern): bool
+    {
+        $regex = '/^'.str_replace('\*', '.*', preg_quote($pattern, '/')).'$/i';
+
+        return preg_match($regex, $username) === 1;
+    }
+}