Merge pull request #6 from codyoss/master

fixing some linter warning and documentation

Author: PeterIvanov

builder.go

@@ -20,11 +20,10 @@ type ErrorBuilder struct {
 // NewErrorBuilder creates error builder from an existing error type.
 func NewErrorBuilder(t *Type) *ErrorBuilder {
 	getMode := func() callStackBuildMode {
-		if t.modifiers.CollectStackTrace() {
-			return stackTraceCollect
-		} else {
+		if !t.modifiers.CollectStackTrace() {
 			return stackTraceOmit
 		}
+		return stackTraceCollect
 	}
 
 	return &ErrorBuilder{
@@ -136,9 +135,8 @@ func (eb *ErrorBuilder) borrowStackTraceFromCause() *stackTrace {
 	originalStackTrace := eb.extractStackTraceFromCause(eb.cause)
 	if originalStackTrace != nil {
 		return originalStackTrace
-	} else {
-		return collectStackTrace()
 	}
+	return collectStackTrace()
 }
 
 func (eb *ErrorBuilder) combineStackTraceWithCause() *stackTrace {

error.go

@@ -173,9 +173,8 @@ func (e *Error) Error() string {
 func (e *Error) fullMessage() string {
 	if e.transparent {
 		return e.messageWithUnderlyingInfo()
-	} else {
-		return joinStringsIfNonEmpty(": ", e.errorType.FullName(), e.messageWithUnderlyingInfo())
 	}
+	return joinStringsIfNonEmpty(": ", e.errorType.FullName(), e.messageWithUnderlyingInfo())
 }
 
 func (e *Error) messageWithUnderlyingInfo() string {

namespace.go

@@ -105,17 +105,15 @@ func newNamespace(parent *Namespace, name string, traits ...Trait) Namespace {
 	createName := func() string {
 		if parent == nil {
 			return name
-		} else {
-			return fmt.Sprintf("%s.%s", parent.FullName(), name)
 		}
+		return fmt.Sprintf("%s.%s", parent.FullName(), name)
 	}
 
 	createModifiers := func() modifiers {
 		if parent == nil {
 			return noModifiers{}
-		} else {
-			return newInheritedModifiers(parent.modifiers)
 		}
+		return newInheritedModifiers(parent.modifiers)
 	}
 
 	namespace := Namespace{

switch.go

@@ -1,6 +1,6 @@
 package errorx
 
-// CaseNoTrait is a synthetic type used in TypeSwitch, signifying a presence of non-nil error of some other type.
+// NotRecognisedType is a synthetic type used in TypeSwitch, signifying a presence of non-nil error of some other type.
 func NotRecognisedType() *Type { return notRecognisedType }
 
 // CaseNoError is a synthetic trait used in TraitSwitch, signifying an absence of error.

type.go

@@ -123,9 +123,8 @@ func newType(namespace Namespace, parent *Type, name string, traits ...Trait) *T
 	collectModifiers := func() modifiers {
 		if parent == nil {
 			return newInheritedModifiers(namespace.modifiers)
-		} else {
-			return newInheritedModifiers(parent.modifiers)
 		}
+		return newInheritedModifiers(parent.modifiers)
 	}
 
 	collectTraits := func() map[Trait]bool {
@@ -150,9 +149,8 @@ func newType(namespace Namespace, parent *Type, name string, traits ...Trait) *T
 	createFullName := func() string {
 		if parent == nil {
 			return namespace.FullName() + "." + name
-		} else {
-			return parent.FullName() + "." + name
 		}
+		return parent.FullName() + "." + name
 	}
 
 	t := &Type{

wrap.go

@@ -65,11 +65,10 @@ func DecorateMany(message string, errs ...error) error {
 		return nil
 	}
 
-	if areAllOfTheSameType(errs...) {
-		return WrapMany(transparentWrapper, message, errs...)
-	} else {
+	if !areAllOfTheSameType(errs...) {
 		return WrapMany(opaqueWrapper, message, errs...)
 	}
+	return WrapMany(transparentWrapper, message, errs...)
 }
 
 // WrapMany is a utility to wrap multiple errors.
@@ -110,9 +109,8 @@ func areAllOfTheSameType(errs ...error) bool {
 
 		if errorType != nil && errorType != typedError.Type() {
 			return false
-		} else {
-			errorType = typedError.Type()
 		}
+		errorType = typedError.Type()
 	}
 
 	return true