Skip to content

Commit 4ea1532

Browse files
committed
Removed Joomla 4 warning
Fixed branch filter Set Yes as first option in filters Signed-off-by: Roland Dalmulder <contact@rolandd.com>
1 parent 39c5db6 commit 4ea1532

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

administrator/components/com_patchtester/PatchTester/Model/PullsModel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ protected function getListQuery()
247247
if (!empty($branch))
248248
{
249249
$query->where(
250-
$db->quoteName('pulls.branch') . ' = ' . $db->quote($branch)
250+
$db->quoteName('pulls.branch') . ' IN (' . implode(',', $db->quote($branch)) . ')'
251251
);
252252
}
253253

administrator/components/com_patchtester/PatchTester/View/Pulls/PullsHtmlView.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
namespace PatchTester\View\Pulls;
1010

1111
use Exception;
12-
use Joomla\CMS\Factory;
1312
use Joomla\CMS\Form\Form;
1413
use Joomla\CMS\Language\Text;
1514
use Joomla\CMS\Pagination\Pagination;
@@ -127,11 +126,6 @@ public function render(): string
127126

128127
Text::script('COM_PATCHTESTER_CONFIRM_RESET');
129128

130-
if (version_compare(JVERSION, '4.0', 'ge'))
131-
{
132-
Factory::getApplication()->enqueueMessage(Text::_('COM_PATCHTESTER_40_WARNING'), 'warning');
133-
}
134-
135129
return parent::render();
136130
}
137131

administrator/components/com_patchtester/forms/filter_pulls.xml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@
1414
type="list"
1515
default=""
1616
validate="options"
17+
onchange="this.form.submit();"
1718
>
1819
<option value="">COM_PATCHTESTER_FILTER_APPLIED_PATCHES</option>
19-
<option value="0">JNO</option>
2020
<option value="1">JYES</option>
21+
<option value="0">JNO</option>
2122
</field>
2223

2324

@@ -26,21 +27,23 @@
2627
type="list"
2728
default=""
2829
validate="options"
30+
onchange="this.form.submit();"
2931
>
3032
<option value="">COM_PATCHTESTER_FILTER_RTC_PATCHES</option>
31-
<option value="0">JNO</option>
3233
<option value="1">JYES</option>
34+
<option value="0">JNO</option>
3335
</field>
3436

3537
<field
3638
name="npm"
3739
type="list"
3840
default=""
3941
validate="options"
42+
onchange="this.form.submit();"
4043
>
4144
<option value="">COM_PATCHTESTER_FILTER_NPM_PATCHES</option>
42-
<option value="0">JNO</option>
4345
<option value="1">JYES</option>
46+
<option value="0">JNO</option>
4447
</field>
4548

4649
<field

0 commit comments

Comments
 (0)