Merge pull request github#11576 from ethanwilloner/main

hvitved · web-flow · commit 51f11f19cccd · 2022-12-07T09:34:51.000+01:00
csharp: URI should be Uri in Owin.qll library.
diff --git a/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll b/csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll
@@ -118,10 +118,10 @@ class MicrosoftOwinIOwinRequestClass extends Class {
     result.hasName("Scheme")
   }
 
-  /** Gets the `URI` property. */
+  /** Gets the `Uri` property. */
   Property getUriProperty() {
     result = this.getAProperty() and
-    result.hasName("URI")
+    result.hasName("Uri")
   }
 
   /** DEPRECATED: Alias for getUriProperty */
diff --git a/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md b/csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md
@@ -0,0 +1,4 @@
+---
+category: fix
+---
+* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class.

Original file line number	Diff line number	Diff line change
`@@ -118,10 +118,10 @@ class MicrosoftOwinIOwinRequestClass extends Class {`
`118`	`118`	`result.hasName("Scheme")`
`119`	`119`	`}`
`120`	`120`
`121`		- /** Gets the `URI` property. */
	`121`	+ /** Gets the `Uri` property. */
`122`	`122`	`Property getUriProperty() {`
`123`	`123`	`result = this.getAProperty() and`
`124`		`- result.hasName("URI")`
	`124`	`+ result.hasName("Uri")`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`/** DEPRECATED: Alias for getUriProperty */`
-Original file line number
+Diff line change
@@ @@ -0,0 +1,4 @@ @@
 +---
 +category: fix
 +---
 +* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class.