Swift: fix remapping bug

AlexDenisov · AlexDenisov · commit 8f02463411ef · 2022-11-22T17:25:07.000+01:00
This issue has slipped during a recent refactoring: https://github.com/github/codeql/pull/10987/files#diff-c5ab26a06a93c4507a834859a6a56878d5bfe16c4d7cbac4afc4f081d46f461aL63-R64
diff --git a/swift/extractor/remapping/SwiftOpenInterception.macOS.cpp b/swift/extractor/remapping/SwiftOpenInterception.macOS.cpp
@@ -61,7 +61,7 @@ void finalizeRemapping(
     }
     auto hash = originalHashFile(original);
     auto hashed = scratchDir / hash;
-    if (!hash.empty() && fs::exists(hashed)) {
+    if (!hash.empty() && fs::exists(patched)) {
       std::error_code ec;
       fs::create_symlink(/* target */ patched, /* symlink */ hashed, ec);
       if (ec) {

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ void finalizeRemapping(`
`61`	`61`	`}`
`62`	`62`	`auto hash = originalHashFile(original);`
`63`	`63`	`auto hashed = scratchDir / hash;`
`64`		`- if (!hash.empty() && fs::exists(hashed)) {`
	`64`	`+ if (!hash.empty() && fs::exists(patched)) {`
`65`	`65`	`std::error_code ec;`
`66`	`66`	`fs::create_symlink(/* target / patched, / symlink */ hashed, ec);`
`67`	`67`	`if (ec) {`