Simplify DiagnosticClassifier in CSharpAutobuilder

mbg · mbg · commit 93a45fce5ef0 · 2023-03-01T14:58:49.000Z
diff --git a/csharp/autobuilder/Semmle.Autobuild.CSharp/CSharpAutobuilder.cs b/csharp/autobuilder/Semmle.Autobuild.CSharp/CSharpAutobuilder.cs
@@ -36,14 +36,12 @@ public class CSharpAutobuilder : Autobuilder<CSharpAutobuildOptions>
 
         private readonly AutoBuildRule autoBuildRule;
 
-        private readonly DiagnosticClassifier diagnosticClassifier;
-
-        protected override DiagnosticClassifier DiagnosticClassifier => diagnosticClassifier;
+        protected override DiagnosticClassifier DiagnosticClassifier { get; }
 
         public CSharpAutobuilder(IBuildActions actions, CSharpAutobuildOptions options) : base(actions, options)
         {
             this.autoBuildRule = new AutoBuildRule(this);
-            this.diagnosticClassifier = new CSharpDiagnosticClassifier();
+            this.DiagnosticClassifier = new CSharpDiagnosticClassifier();
         }
 
         public override BuildScript GetBuildScript()

Original file line number	Diff line number	Diff line change
`@@ -36,14 +36,12 @@ public class CSharpAutobuilder : Autobuilder<CSharpAutobuildOptions>`
`36`	`36`
`37`	`37`	`private readonly AutoBuildRule autoBuildRule;`
`38`	`38`
`39`		`- private readonly DiagnosticClassifier diagnosticClassifier;`
`40`		`-`
`41`		`- protected override DiagnosticClassifier DiagnosticClassifier => diagnosticClassifier;`
	`39`	`+ protected override DiagnosticClassifier DiagnosticClassifier { get; }`
`42`	`40`
`43`	`41`	`public CSharpAutobuilder(IBuildActions actions, CSharpAutobuildOptions options) : base(actions, options)`
`44`	`42`	`{`
`45`	`43`	`this.autoBuildRule = new AutoBuildRule(this);`
`46`		`- this.diagnosticClassifier = new CSharpDiagnosticClassifier();`
	`44`	`+ this.DiagnosticClassifier = new CSharpDiagnosticClassifier();`
`47`	`45`	`}`
`48`	`46`
`49`	`47`	`public override BuildScript GetBuildScript()`