Add test for existence of all the native strings (#15)

Evgeny Barabanov · web-flow · commit a0299afc943c · 2018-02-23T14:11:59.000+02:00
* Add test for existence of all the native strings

* Fix appveyor.yml to avoid conflict of nodejs platform variable with system platform variable
diff --git a/appveyor.yml b/appveyor.yml
@@ -3,20 +3,22 @@ image: Visual Studio 2015
 environment:
   BASH: C:/cygwin/bin/bash
 
-platform:
-  - x86
-  - x64
+  matrix:
+    - node_platform: x86
+      dist_platform: 32
+    - node_platform: x64
+      dist_platform: 64
 
 cache:
   - node_modules
 
 install:
-  - ps: Install-Product node LTS $env:platform
+  - ps: Install-Product node LTS $env:node_platform
   - npm config set msvs_version 2015
   - '%BASH% -lc "cd $APPVEYOR_BUILD_FOLDER && npm install"'
 
 build: off
 
 test_script:
-  - '%BASH% -lc "cd $APPVEYOR_BUILD_FOLDER && npm run dist"'
-  - '%BASH% -lc "cd $APPVEYOR_BUILD_FOLDER && npm run e2e"'
+  - '%BASH% -lc "cd $APPVEYOR_BUILD_FOLDER && npm run dist:windows:$dist_platform"'
+  - npm run e2e
diff --git a/e2e/common/spectron-utils.ts b/e2e/common/spectron-utils.ts
@@ -16,17 +16,13 @@ const platformToExtension = {
 
 export class SpectronUtils {
   public static app = new SpectronApplication({
-    // Your electron path can be any binary
-    // i.e for OSX an example path could be '/Applications/MyApp.app/Contents/MacOS/MyApp'
-    // But for the sake of the example we fetch it from our node_modules.
     path: `build-artifacts/ElectronAngularNativeApp.${platformToExtension[process.platform]}`,
-    args: [path.join(__dirname, '../..')],
   });
 
   static describe(desc: string, describeFunction: (app: Application) => void) {
 
     describe(desc, function () {
-      this.timeout(20000);
+      this.timeout(10000);
 
       before(() => {
         return SpectronUtils.app.start();
diff --git a/e2e/native-strings.e2e-spec.ts b/e2e/native-strings.e2e-spec.ts
@@ -0,0 +1,26 @@
+import {SpectronUtils} from './common/spectron-utils';
+import {Application} from 'spectron';
+import * as path from 'path';
+import * as fs from 'fs';
+
+const chaiAsPromised = require('chai-as-promised');
+const chai = require('chai');
+
+chai.should();
+chai.use(chaiAsPromised);
+
+function containsString(app: Application, str: string) {
+  it(`Contains ${str}`,
+    () => {
+    return app.client.waitForExist('ul li h2').then(() => app.client.getText('ul li h2').then(list => {
+        const index = list.indexOf(str);
+        return index > -1 ? list[index] : '';
+      }).should.eventually.equal(str));
+    }
+  );
+}
+
+SpectronUtils.describe('Native strings', app => {
+  containsString(app, 'c++ .node string');
+  containsString(app, 'c++ precompiled library string');
+});
diff --git a/src/index.html b/src/index.html
@@ -6,7 +6,7 @@
   <base href="./">
 
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <link rel="icon" type="image/x-icon" href="favicon.ico">
+  <link rel="icon" type="image/x-icon" href="favicon.png">
 </head>
 <body>
   <app-root></app-root>
