Skip to content

Commit 311ce97

Browse files
marcospskdave
authored andcommitted
btrfs-progs: restore: remove stale debug message
The message was introduced on 502d287 ("btrfs-progs: restore: add global verbose option"), and it was never changed. The debug message shows the offset of one EXTENT_DATA from the file being restore, but it's only shown when it's not zero. This field is non-zero when the extent was first snapshotted (or a subvolume was created), and later changed partially, so the extent was split in the part that remained the same and the one that changed. It's not useful to have this message being printed without proper context to the end user. The message itself isn't very useful in debugging sessions, since it would be necessary more data about a problematic file/extent. And given that the message is here for more than 5 years being unnecessary printed, it's better to remove it since it can annoy the users. If a problem appears at this point in the code, a more appropriate debug code could be introduced instead. Link: #920 Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 7b5a34e commit 311ce97

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

cmds/restore.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,8 +391,6 @@ static int copy_one_extent(struct btrfs_root *root, int fd,
391391
size_left -= offset;
392392
}
393393

394-
pr_verbose(offset ? 1 : 0, "offset is %llu\n", offset);
395-
396394
inbuf = malloc(size_left);
397395
if (!inbuf) {
398396
error_msg(ERROR_MSG_MEMORY, NULL);

0 commit comments

Comments
 (0)