chore: reformat scaler code to match KEDA go style (#1295)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

Author: zroubalik

scaler/handlers.go

@@ -45,12 +45,7 @@ type impl struct {
 	externalscaler.UnimplementedExternalScalerServer
 }
 
-func newImpl(
-	lggr logr.Logger,
-	pinger *queuePinger,
-	httpsoInformer informershttpv1alpha1.HTTPScaledObjectInformer,
-	defaultTargetMetric int64,
-) *impl {
+func newImpl(lggr logr.Logger, pinger *queuePinger, httpsoInformer informershttpv1alpha1.HTTPScaledObjectInformer, defaultTargetMetric int64) *impl {
 	return &impl{
 		lggr:           lggr,
 		pinger:         pinger,
@@ -63,10 +58,7 @@ func (e *impl) Ping(context.Context, *emptypb.Empty) (*emptypb.Empty, error) {
 	return &emptypb.Empty{}, nil
 }
 
-func (e *impl) IsActive(
-	ctx context.Context,
-	sor *externalscaler.ScaledObjectRef,
-) (*externalscaler.IsActiveResponse, error) {
+func (e *impl) IsActive(ctx context.Context, sor *externalscaler.ScaledObjectRef) (*externalscaler.IsActiveResponse, error) {
 	lggr := e.lggr.WithName("IsActive")
 
 	gmr, err := e.GetMetrics(ctx, &externalscaler.GetMetricsRequest{
@@ -91,10 +83,7 @@ func (e *impl) IsActive(
 	return res, nil
 }
 
-func (e *impl) StreamIsActive(
-	scaledObject *externalscaler.ScaledObjectRef,
-	server externalscaler.ExternalScaler_StreamIsActiveServer,
-) error {
+func (e *impl) StreamIsActive(scaledObject *externalscaler.ScaledObjectRef, server externalscaler.ExternalScaler_StreamIsActiveServer) error {
 	// this function communicates with KEDA via the 'server' parameter.
 	// we call server.Send (below) every streamInterval, which tells it to immediately
 	// ping our IsActive RPC
@@ -127,10 +116,7 @@ func (e *impl) StreamIsActive(
 	}
 }
 
-func (e *impl) GetMetricSpec(
-	_ context.Context,
-	sor *externalscaler.ScaledObjectRef,
-) (*externalscaler.GetMetricSpecResponse, error) {
+func (e *impl) GetMetricSpec(_ context.Context, sor *externalscaler.ScaledObjectRef) (*externalscaler.GetMetricSpecResponse, error) {
 	lggr := e.lggr.WithName("GetMetricSpec")
 
 	namespacedName := k8s.NamespacedNameFromScaledObjectRef(sor)
@@ -189,10 +175,7 @@ func (e *impl) interceptorMetricSpec(metricName string, interceptorTargetPending
 	return res, nil
 }
 
-func (e *impl) GetMetrics(
-	_ context.Context,
-	metricRequest *externalscaler.GetMetricsRequest,
-) (*externalscaler.GetMetricsResponse, error) {
+func (e *impl) GetMetrics(_ context.Context, metricRequest *externalscaler.GetMetricsRequest) (*externalscaler.GetMetricsResponse, error) {
 	lggr := e.lggr.WithName("GetMetrics")
 	sor := metricRequest.ScaledObjectRef
 
@@ -222,8 +205,7 @@ func (e *impl) GetMetrics(
 	count := e.pinger.counts()[key]
 
 	var metricValue int
-	if httpso.Spec.ScalingMetric != nil &&
-		httpso.Spec.ScalingMetric.Rate != nil {
+	if httpso.Spec.ScalingMetric != nil && httpso.Spec.ScalingMetric.Rate != nil {
 		metricValue = int(math.Ceil(count.RPS))
 		lggr.V(1).Info(fmt.Sprintf("%d rps for %s", metricValue, httpso.GetName()))
 	} else {

scaler/main.go

@@ -64,14 +64,7 @@ func main() {
 		setupLog.Error(err, "creating new Kubernetes ClientSet")
 		os.Exit(1)
 	}
-	pinger := newQueuePinger(
-		ctrl.Log,
-		k8s.EndpointsFuncForK8sClientset(k8sCl),
-		namespace,
-		svcName,
-		deplName,
-		targetPortStr,
-	)
+	pinger := newQueuePinger(ctrl.Log, k8s.EndpointsFuncForK8sClientset(k8sCl), namespace, svcName, deplName, targetPortStr)
 
 	// create the endpoints informer
 	endpInformer := k8s.NewInformerBackedEndpointsCache(
@@ -141,15 +134,7 @@ func main() {
 	setupLog.Info("Bye!")
 }
 
-func startGrpcServer(
-	ctx context.Context,
-	cfg *config,
-	lggr logr.Logger,
-	port int,
-	pinger *queuePinger,
-	httpsoInformer informershttpv1alpha1.HTTPScaledObjectInformer,
-	targetPendingRequests int64,
-) error {
+func startGrpcServer(ctx context.Context, cfg *config, lggr logr.Logger, port int, pinger *queuePinger, httpsoInformer informershttpv1alpha1.HTTPScaledObjectInformer, targetPendingRequests int64) error {
 	addr := fmt.Sprintf("0.0.0.0:%d", port)
 	lggr.Info("starting grpc server", "address", addr)
 
@@ -188,20 +173,9 @@ func startGrpcServer(
 		}
 	}()
 
-	grpc_health_v1.RegisterHealthServer(
-		grpcServer,
-		hs,
-	)
+	grpc_health_v1.RegisterHealthServer(grpcServer, hs)
 
-	externalscaler.RegisterExternalScalerServer(
-		grpcServer,
-		newImpl(
-			lggr,
-			pinger,
-			httpsoInformer,
-			targetPendingRequests,
-		),
-	)
+	externalscaler.RegisterExternalScalerServer(grpcServer, newImpl(lggr, pinger, httpsoInformer, targetPendingRequests))
 
 	go func() {
 		<-ctx.Done()

scaler/queue_pinger.go

@@ -54,14 +54,7 @@ type queuePinger struct {
 	status                 PingerStatus
 }
 
-func newQueuePinger(
-	lggr logr.Logger,
-	getEndpointsFn k8s.GetEndpointsFunc,
-	ns,
-	svcName,
-	deplName,
-	adminPort string,
-) *queuePinger {
+func newQueuePinger(lggr logr.Logger, getEndpointsFn k8s.GetEndpointsFunc, ns, svcName, deplName, adminPort string) *queuePinger {
 	pingMut := new(sync.RWMutex)
 	pinger := &queuePinger{
 		getEndpointsFn:         getEndpointsFn,
@@ -77,11 +70,7 @@ func newQueuePinger(
 }
 
 // start starts the queuePinger
-func (q *queuePinger) start(
-	ctx context.Context,
-	ticker *time.Ticker,
-	endpCache k8s.EndpointsCache,
-) error {
+func (q *queuePinger) start(ctx context.Context, ticker *time.Ticker, endpCache k8s.EndpointsCache) error {
 	endpoWatchIface, err := endpCache.Watch(q.interceptorNS, q.interceptorServiceName)
 	if err != nil {
 		return err
@@ -132,14 +121,7 @@ func (q *queuePinger) counts() map[string]queue.Count {
 func (q *queuePinger) fetchAndSaveCounts(ctx context.Context) error {
 	q.pingMut.Lock()
 	defer q.pingMut.Unlock()
-	counts, err := fetchCounts(
-		ctx,
-		q.lggr,
-		q.getEndpointsFn,
-		q.interceptorNS,
-		q.interceptorSvcName,
-		q.adminPort,
-	)
+	counts, err := fetchCounts(ctx, q.lggr, q.getEndpointsFn, q.interceptorNS, q.interceptorSvcName, q.adminPort)
 	if err != nil {
 		q.lggr.Error(err, "getting request counts")
 		q.status = PingerERROR
@@ -161,23 +143,10 @@ func (q *queuePinger) fetchAndSaveCounts(ctx context.Context) error {
 //
 // Upon any failure, a non-nil error is returned and the
 // other two return values are nil and 0, respectively.
-func fetchCounts(
-	ctx context.Context,
-	lggr logr.Logger,
-	endpointsFn k8s.GetEndpointsFunc,
-	ns,
-	svcName,
-	adminPort string,
-) (map[string]queue.Count, error) {
+func fetchCounts(ctx context.Context, lggr logr.Logger, endpointsFn k8s.GetEndpointsFunc, ns, svcName, adminPort string) (map[string]queue.Count, error) {
 	lggr = lggr.WithName("queuePinger.requestCounts")
 
-	endpointURLs, err := k8s.EndpointsForService(
-		ctx,
-		ns,
-		svcName,
-		adminPort,
-		endpointsFn,
-	)
+	endpointURLs, err := k8s.EndpointsForService(ctx, ns, svcName, adminPort, endpointsFn)
 	if err != nil {
 		return nil, err
 	}