Skip to content

Commit 94547f7

Browse files
authored
Merge branch 'master' into CatalinAnt-patch-1
2 parents 175e67a + f8ed727 commit 94547f7

File tree

1 file changed

+23
-6
lines changed

1 file changed

+23
-6
lines changed

README.md

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ In order to not put in 8 large images, I will insert the final screenshot, with
3939

4040
#### Catalin Antonescu
4141

42-
#### Function 1: strong_password
42+
##### Function 1: strong_password
4343

4444
Link to commit:
4545
[https://github.com/CatalinAnt/algorithms-SEP-95/commit/eaad6d32ecd73bb8fde876a4d4852cb522aea6f8](https://github.com/CatalinAnt/algorithms-SEP-95/commit/2b0b9187c1c040e4476b1ca14f2c2249273566b7)
4646

4747
Screenshot of branch measurement:
4848
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/e718a47f-5ea0-412c-b250-25a193412164)
4949

50-
#### Function 2: rotate_image
50+
##### Function 2: rotate_image
5151

5252
Link to commit:(same as for the first one)
5353
[https://github.com/CatalinAnt/algorithms-SEP-95/commit/eaad6d32ecd73bb8fde876a4d4852cb522aea6f8](https://github.com/CatalinAnt/algorithms-SEP-95/commit/2b0b9187c1c040e4476b1ca14f2c2249273566b7)
@@ -72,6 +72,23 @@ https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4
7272
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
7373

7474

75+
#### Abdullah Abdelkhalik
76+
77+
78+
pythagoras
79+
80+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e74883bb991acf19303
81+
82+
![pythagoras_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/0df1fa2b-2185-4b9f-ae65-5d969edb009b)
83+
84+
85+
first_unique_char
86+
87+
https://github.com/CatalinAnt/algorithms-SEP-95/commit/c16f26e952322b2c1729778a4141a57103ba7658
88+
89+
![first_unique_char_hits](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10d7c45c-398e-4408-8f11-6771f51fa95c)
90+
91+
7592

7693
## Coverage improvement
7794

@@ -153,7 +170,7 @@ New coverage:
153170
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/1d179cc4-1179-40e2-b344-5e904e899647)
154171
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/c8173a47-bcc9-4b6a-9a91-c70b5a8b002f)
155172

156-
For strong_password there was a 26% coverage improvement with tthe existing tool and 40% with manual measurement tool.
173+
For strong_password there was a 26% coverage improvement with the existing tool and 40% with manual measurement tool.
157174

158175

159176
Test 2:
@@ -172,9 +189,9 @@ New coverage:
172189

173190
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/7cc337eb-5684-40b3-aedd-dc2b7180b7f3)
174191
![image](https://github.com/CatalinAnt/algorithms-SEP-95/assets/113595149/2143adff-e0aa-4113-858a-0c92ec288d20)
192+
For rotate_image, thre was a 33% coverage improvement with the existing tool and 25% with manual tool.
175193

176-
For rotate_image, thre was a 33% coverage improvement with the existing tool and 25% with manual tool.
177-
194+
178195
## Abdullah Abdelkhalik
179196

180197
test_maths
@@ -195,7 +212,7 @@ https://github.com/CatalinAnt/algorithms-SEP-95/commit/5651abafebe8ae3a5ea63e748
195212

196213
![first_unique_char_after](https://github.com/CatalinAnt/algorithms-SEP-95/assets/114078193/10859fac-776c-4a48-8a1c-9531afcbfa9b)
197214

198-
the coverage is improved by 13%, the code only hit three out of five branches and only set up two examples. I added a case where there is no unique letter.
215+
The coverage is improved by 13%, the code only hit three out of five branches and only set up two examples. I added a case where there is no unique letter.
199216

200217

201218
### Overall

0 commit comments

Comments
 (0)