fix: push a new element to the last when the index is out of range

Author: Kevin Hermawan

src/insertAt.ts

@@ -7,11 +7,7 @@ export function insertAt<T>(array: T[], args: InsertAtArgs<T>) {
   const { index, element } = args;
   const lastIndex = array.length - 1;
 
-  if (index > lastIndex) {
-    return array;
-  }
-
-  if (index === lastIndex) {
+  if (index === lastIndex || index > lastIndex) {
     const result = array;
     result.push(element);
 

test/insertAt.test.ts

@@ -10,24 +10,24 @@ describe('insertAt', () => {
     expect(result).to.eql([9, 1, 2, 3, 4, 5]);
   });
 
-  // it('inserts element into the middle', () => {
-  //   const array = [1, 2, 3, 4, 5];
+  it('inserts element into the middle', () => {
+    const array = [1, 2, 3, 4, 5];
 
-  //   const result = insertAt(array, { index: 3, element: 9 });
-  //   expect(result).to.eql([1, 2, 3, 9, 4, 5]);
-  // });
+    const result = insertAt(array, { index: 3, element: 9 });
+    expect(result).to.eql([1, 2, 3, 9, 4, 5]);
+  });
 
-  // it('inserts element into the last', () => {
-  //   const array = [1, 2, 3, 4, 5];
+  it('inserts element into the last', () => {
+    const array = [1, 2, 3, 4, 5];
 
-  //   const result = insertAt(array, { index: array.length - 1, element: 9 });
-  //   expect(result).to.eql([1, 2, 3, 4, 5, 9]);
-  // });
+    const result = insertAt(array, { index: array.length - 1, element: 9 });
+    expect(result).to.eql([1, 2, 3, 4, 5, 9]);
+  });
 
-  // it('handles index out of range', () => {
-  //   const array = [1, 2, 3, 4, 5];
+  it('handles index out of range', () => {
+    const array = [1, 2, 3, 4, 5];
 
-  //   const result = insertAt(array, { index: 99, element: 9 });
-  //   expect(result).to.eql([1, 2, 3, 4, 5, 9]);
-  // });
+    const result = insertAt(array, { index: 99, element: 9 });
+    expect(result).to.eql([1, 2, 3, 4, 5, 9]);
+  });
 });