Skip to content

Fix Serving Metric Queue Names + add HTTP Metrics #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 2 commits into from
Dec 4, 2025
Merged

Fix Serving Metric Queue Names + add HTTP Metrics #6533

knative-prow merged 2 commits into from
Dec 4, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Dec 3, 2025 •
edited
Loading

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@netlify
Copy link

netlify bot commented Dec 3, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit e6b487f
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/6930c8ace9887b00081df7da
😎 Deploy Preview https://deploy-preview-6533--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

/cherry-pick release-1.19
/cherry-pick release-1.20

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 3, 2025

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19, release-1.20 in new PRs and assign them to you.

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

cc @Cali0707

@dprotaso
Copy link
Member Author

dprotaso commented Dec 3, 2025

/assign @Cali0707
cc @linkvt

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2025
@dprotaso dprotaso changed the title Fix Serving Metric Queue Names Fix Serving Metric Queue Names + add HTTP Metrics Dec 3, 2025
@dprotaso dprotaso mentioned this pull request Dec 3, 2025
Open
Cali0707
Cali0707 approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2025
@knative-prow
Copy link

knative-prow bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9a1b5dc into knative:main Dec 4, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 4, 2025

@dprotaso: new pull request created: #6535

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Dec 4, 2025
Open
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 4, 2025

@dprotaso: new pull request created: #6536

In response to this:

/cherry-pick release-1.19
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Dec 4, 2025
Open
@dprotaso dprotaso deleted the fix-metric-names branch December 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zainabhusain227 zainabhusain227 Awaiting requested review from zainabhusain227

1 more reviewer

@Cali0707 Cali0707 Cali0707 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @knative-prow-robot @Cali0707