AP-25000: Fix sonar issues

AP-25000 (Agent Chat View to output conversation - base version)

Author: hornm-knime

org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/CloseablePythonNodeProxy.java

@@ -962,7 +962,6 @@ public String handleJsonRpcRequest(final String request) {
             public BackendViewData getViewData() {
                 var viewData = pythonDataService.getViewData();
                 var conversionContext = new PortObjectConversionContext(fileStoresByKey, m_tableManager, exec);
-                var ports = viewData.ports();
                 var portObjects = viewData.ports().stream() //
                     .map(po -> PythonPortTypeRegistry.convertPortObjectFromPython(po, conversionContext))//
                     .toArray(PortObject[]::new);

org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/DefaultViewContext.java

@@ -52,7 +52,6 @@
 import java.util.Map;
 
 import org.knime.core.node.workflow.ICredentials;
-import org.knime.python3.nodes.DelegatingNodeModel.ViewData.BackendViewData;
 import org.knime.python3.nodes.ports.PythonPortObjects.PurePythonTablePortObject;
 import org.knime.python3.nodes.ports.PythonPortObjects.PythonPortObject;
 import org.knime.python3.nodes.proxy.PythonNodeViewProxy;

org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/DelegatingNodeModel.java

@@ -54,7 +54,6 @@
 import java.io.DataOutputStream;
 import java.io.File;
 import java.io.FileInputStream;
-import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.nio.file.Path;
@@ -496,13 +495,13 @@ public void disposeDataServiceProxy() throws Exception {
      * {@link DataServiceProxy#getViewData()}; served back to python via {@link PythonViewContext#get_view_data()} (for
      * the view's data service) and via {@link PythonExecutionContext#get_view_data()} (for the node re-execution)</li>
      */
-    public static class ViewData {
+    public final static class ViewData {
 
         private BackendViewData m_backendData;
 
         private String m_frontendData;
 
-        private boolean m_doPersist = false;
+        private boolean m_doPersist;
 
         private void setFrontendData(final String frontendData) {
             m_frontendData = frontendData;
@@ -555,7 +554,7 @@ private void save(final File nodeInternDir) throws IOException {
             }
         }
 
-        private static ViewData load(final File nodeInternDir) throws FileNotFoundException, IOException {
+        private static ViewData load(final File nodeInternDir) throws IOException {
             File f = new File(nodeInternDir, "internal_view_data.gz");
             if (f.exists()) {
                 try (DataInputStream in =

org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/proxy/NodeViewProxy.java

@@ -95,7 +95,8 @@ interface ViewEnvironment extends PortMapProvider, CredentialsProviderProxy {
      *
      * @return a data service that is powered by a remote proxy
      */
-    DataServiceProxy getDataServiceProxy(JsonNodeSettings settings, final PortObject[] portObjects, BackendViewData viewData,
-        final PortMapProvider portMapProvider, final CredentialsProviderProxy credentialsProvider);
+    DataServiceProxy getDataServiceProxy(JsonNodeSettings settings, final PortObject[] portObjects,
+        BackendViewData viewData, final PortMapProvider portMapProvider,
+        final CredentialsProviderProxy credentialsProvider);
 
 }

org.knime.python3.nodes/src/main/java/org/knime/python3/nodes/proxy/PythonNodeViewProxy.java

@@ -90,6 +90,9 @@ interface PythonDataServiceProxy {
          */
         PythonViewData getViewData();
 
+        /**
+         * Used to communicate the view data between the Java and Python.
+         */
         interface PythonViewData {
 
             String data();