From c67258c15dadf327e76320e5680483a74d04e433 Mon Sep 17 00:00:00 2001 From: David Koblas Date: Mon, 9 Jun 2025 04:30:13 -0400 Subject: [PATCH 1/2] chore: had cursor review tests and find discrepancies --- src/al/nipt.spec.ts | 2 +- src/gh/tin.spec.ts | 4 ++-- src/lk/nic.spec.ts | 9 +-------- src/pe/ce.spec.ts | 2 +- src/tw/natid.spec.ts | 13 ++++++++----- 5 files changed, 13 insertions(+), 17 deletions(-) diff --git a/src/al/nipt.spec.ts b/src/al/nipt.spec.ts index aeefe4b4..b15e6f9c 100644 --- a/src/al/nipt.spec.ts +++ b/src/al/nipt.spec.ts @@ -1,7 +1,7 @@ import { validate, format } from './nipt'; import { InvalidLength, InvalidFormat } from '../exceptions'; -describe('al/nibt', () => { +describe('al/nipt', () => { it('format:AL J 91402501 L', () => { const result = format('AL J 91402501 L'); diff --git a/src/gh/tin.spec.ts b/src/gh/tin.spec.ts index 5e9b3e64..b58a7c18 100644 --- a/src/gh/tin.spec.ts +++ b/src/gh/tin.spec.ts @@ -1,7 +1,7 @@ import { validate, format } from './tin'; import { InvalidLength, InvalidChecksum } from '../exceptions'; -describe('gn/tin', () => { +describe('gh/tin', () => { it('format:C0000803561', () => { const result = format('C0000803561'); @@ -29,7 +29,7 @@ describe('gn/tin', () => { }); it('validate:C000080356', () => { - const result = validate('12345678'); + const result = validate('C000080356'); expect(result.error).toBeInstanceOf(InvalidLength); }); diff --git a/src/lk/nic.spec.ts b/src/lk/nic.spec.ts index 5644ae59..09678569 100644 --- a/src/lk/nic.spec.ts +++ b/src/lk/nic.spec.ts @@ -20,21 +20,14 @@ describe('lk/nic', () => { expect(result.isValid && result.compact).toEqual('942281632V'); }); - it('validate:942R81632b', () => { + it('validate:942281632b', () => { const result = validate('942281632b'); expect(result.error).toBeInstanceOf(InvalidFormat); }); - it('validate:942R81632b', () => { - const result = validate('942R81632b'); - - expect(result.error).toBeInstanceOf(InvalidFormat); - }); - it('validate:23417', () => { const result = validate('23417'); expect(result.error).toBeInstanceOf(InvalidLength); }); - }); diff --git a/src/pe/ce.spec.ts b/src/pe/ce.spec.ts index 75fbb9a2..28af59b0 100644 --- a/src/pe/ce.spec.ts +++ b/src/pe/ce.spec.ts @@ -1,7 +1,7 @@ import { validate, format } from './ce'; import { InvalidLength } from '../exceptions'; -describe('pe/cui', () => { +describe('pe/ce', () => { it('format:001766062', () => { const result = format('001766062'); diff --git a/src/tw/natid.spec.ts b/src/tw/natid.spec.ts index b91f8265..599b7404 100644 --- a/src/tw/natid.spec.ts +++ b/src/tw/natid.spec.ts @@ -26,13 +26,16 @@ describe('tw/natid', () => { expect(result.error).toBeInstanceOf(InvalidComponent); }); - test.each(['A200501503', 'A800501509', 'A800501509'])('not-valid:', value => { - const result = validate(value); - expect(result.isValid).toEqual(false); - }); + test.each(['A200501503', 'A800501509', 'A800501509'])( + 'validate:%s', + value => { + const result = validate(value); + expect(result.isValid).toEqual(false); + }, + ); test.each(['A800000014', 'A123456789', 'A100501503', 'A200501505'])( - 'valid:', + 'validate:%s', value => { const result = validate(value); expect(result.isValid).toEqual(true); From de8ea11c2075773116e5174b087718715934bea2 Mon Sep 17 00:00:00 2001 From: David Koblas Date: Mon, 9 Jun 2025 04:34:06 -0400 Subject: [PATCH 2/2] fix duplicate tests --- src/tw/natid.spec.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/tw/natid.spec.ts b/src/tw/natid.spec.ts index 599b7404..a2d3c5d7 100644 --- a/src/tw/natid.spec.ts +++ b/src/tw/natid.spec.ts @@ -26,13 +26,10 @@ describe('tw/natid', () => { expect(result.error).toBeInstanceOf(InvalidComponent); }); - test.each(['A200501503', 'A800501509', 'A800501509'])( - 'validate:%s', - value => { - const result = validate(value); - expect(result.isValid).toEqual(false); - }, - ); + test.each(['A200501503', 'A800501509'])('validate:%s', value => { + const result = validate(value); + expect(result.isValid).toEqual(false); + }); test.each(['A800000014', 'A123456789', 'A100501503', 'A200501505'])( 'validate:%s',