headlamp-plugin: bin: Replace execSync with execFileSync

Author: skoeva

plugins/headlamp-plugin/bin/headlamp-plugin.js

@@ -108,7 +108,7 @@ function create(name, link, noInstall) {
   } else {
     console.log('Installing dependencies...');
     try {
-      child_process.execSync('npm ci', {
+      child_process.execFileSync('npm', ['ci'], {
         stdio: 'inherit',
         cwd: dstFolder,
         encoding: 'utf8',
@@ -603,7 +603,7 @@ function runScriptOnPackages(packageFolder, scriptName, cmdLine, env) {
       console.log(`No node_modules in "${folder}" found. Running npm install...`);
 
       try {
-        child_process.execSync('npm install', {
+        child_process.execFileSync('npm', ['install'], {
           stdio: 'inherit',
           encoding: 'utf8',
         });
@@ -861,17 +861,16 @@ function format(packageFolder, check) {
  * ```
  */
 function getNpmOutdated() {
-  let result = null;
-
   try {
-    result = child_process.execSync('npm outdated --json', {
-      encoding: 'utf8',
-    });
+    return JSON.parse(
+      child_process.execFileSync('npm', ['outdated', '--json'], {
+        encoding: 'utf8',
+      })
+    );
   } catch (error) {
-    // npm outdated exit codes 1 when something is not up to date.
-    result = error.stdout.toString();
+    const output = error && error.stdout ? error.stdout.toString() : '';
+    return JSON.parse(output);
   }
-  return JSON.parse(result);
 }
 
 /**
@@ -1024,15 +1023,23 @@ function upgrade(packageFolder, skipPackageUpdates, headlampPluginVersion) {
    */
   function runCmd(cmd, folder) {
     console.log(`Running cmd:"${cmd}" inside of ${folder} abs: "${resolve(folder)}"`);
-    try {
-      child_process.execSync(cmd, {
-        stdio: 'inherit',
-        encoding: 'utf8',
-      });
-    } catch (e) {
+    const result = child_process.spawnSync(cmd, {
+      shell: true,
+      stdio: 'inherit',
+      encoding: 'utf8',
+      cwd: folder,
+    });
+
+    if (result.error) {
       console.error(`Problem running ${cmd}`);
-      return e.status;
+      return result.status;
     }
+
+    if (result.status !== 0) {
+      console.error(`Problem running ${cmd}`);
+      return result.status;
+    }
+
     return 0;
   }
 
@@ -1260,16 +1267,16 @@ function tsc(packageFolder) {
  * @returns {0 | 1} Exit code, where 0 is success, 1 is failure.
  */
 function storybook(packageFolder) {
-  try {
-    child_process.execSync(
-      './node_modules/.bin/storybook dev -p 6007 -c node_modules/@kinvolk/headlamp-plugin/config/.storybook',
-      {
-        stdio: 'inherit',
-        cwd: packageFolder,
-        encoding: 'utf8',
-      }
-    );
-  } catch (e) {
+  const command =
+    './node_modules/.bin/storybook dev -p 6007 -c node_modules/@kinvolk/headlamp-plugin/config/.storybook';
+  const result = child_process.spawnSync(command, {
+    stdio: 'inherit',
+    cwd: packageFolder,
+    encoding: 'utf8',
+    shell: true,
+  });
+
+  if (result.error || result.status !== 0) {
     console.error(
       `Problem running storybook dev inside of "${packageFolder}" abs: "${resolve(packageFolder)}"`
     );