app: electron: Replace execSync with execFileSync

Author: skoeva

app/electron/main.ts

@@ -14,7 +14,13 @@
  * limitations under the License.
  */
 
-import { ChildProcessWithoutNullStreams, exec, execSync, spawn } from 'child_process';
+import {
+  ChildProcessWithoutNullStreams,
+  exec,
+  execFileSync,
+  spawn,
+  spawnSync,
+} from 'child_process';
 import { randomBytes } from 'crypto';
 import dotenv from 'dotenv';
 import {
@@ -91,7 +97,9 @@ const args = yargs(hideBin(process.argv))
     () => {
       try {
         const backendPath = path.join(process.resourcesPath, 'headlamp-server');
-        const stdout = execSync(`${backendPath} list-plugins`);
+        const stdout = execFileSync(backendPath, ['list-plugins'], {
+          encoding: 'utf-8',
+        });
         process.stdout.write(stdout);
         process.exit(0);
       } catch (error) {
@@ -1090,7 +1098,13 @@ async function getRunningHeadlampPIDs() {
 function killProcess(pid: number) {
   if (process.platform === 'win32') {
     // Otherwise on Windows the process will stick around.
-    execSync('taskkill /pid ' + pid + ' /T /F');
+    const taskKill = spawnSync('taskkill', ['/pid', String(pid), '/T', '/F'], { stdio: 'ignore' });
+    if (taskKill.error) {
+      throw taskKill.error;
+    }
+    if (taskKill.status !== 0) {
+      throw new Error(`taskkill exited with status ${taskKill.status}`);
+    }
   } else {
     process.kill(pid, 'SIGHUP');
   }