Skip to content

Commit a0e99d2

Browse files
committed
Relax criteria for the "Local service not impacted" E2E test
This test has been failing intermittently for a while: STEP: verifying a local, unexported service is reachable via cluster.local [FAILED] Timed out after 10.092s. There is no failure as the matcher passed to Eventually succeeded on its most recent iteration In [It] at: .../mcs-api/e2e/localserviceimpact_test.go:167 So the Eventually in checkAllClustersReachable: Eventually(func(g Gomega) { ... }, "10s").MustPassRepeatedly(50).Should(Succeed()) does succeed but sometimes does not do so 50 times within 10s. So we need to relax these criteria, either increase the timeout or decrease the number of times. I opted for the latter, ie 20 times. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
1 parent 0d87c31 commit a0e99d2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

e2e/localserviceimpact_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"fmt"
2222
"math/rand"
2323
"strings"
24+
"time"
2425

2526
. "github.com/onsi/ginkgo/v2"
2627
. "github.com/onsi/gomega"
@@ -164,7 +165,7 @@ var _ = Describe("Local service not impacted", func() {
164165
clusterID := strings.TrimSpace(string(stdout))
165166
g.Expect(clusterID).To(BeElementOf(clusterIDs))
166167
clusters[clusterID]++
167-
}, "10s").MustPassRepeatedly(50).Should(Succeed())
168+
}).MustPassRepeatedly(20).Within(time.Second * 10).Should(Succeed())
168169
Expect(clusters).To(HaveEach(Not(BeZero())))
169170
}
170171

0 commit comments

Comments
 (0)